Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9f6U0Bxs96s1dMqbpr/ej69cGrnhFRJw211cUCca5qHDd/m5f49Y+4TgP2XWEVruoOEkjdwUSW
 iHmI3NPwl1VQ==
IronPort-SDR: QuUqn96D0XsZj9XK7gbQ58m7XJS/x7VxHIG5SwLXN9XFsbU2ZRcHf87F/h1ZC3DkVP37k0Kvll
 vbyZjY2o/fpQ==
Subject: Re: [PATCH] firmware: stratix10-svc: build only on 64-bit ARM
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        linux-kernel@vger.kernel.org, dinguyen@kernel.org
Cc:     kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
        Arnd Bergmann <arnd@arndb.de>,
        kernel test robot <lkp@intel.com>
References: <20210321184650.10926-1-krzysztof.kozlowski@canonical.com>
From:   Richard Gong <richard.gong@linux.intel.com>
Message-ID: <2d91b502-c3f2-fbe9-641f-ee2b07eb5668@linux.intel.com>
Date:   Wed, 24 Mar 2021 15:33:42 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210321184650.10926-1-krzysztof.kozlowski@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/21/21 1:46 PM, Krzysztof Kozlowski wrote:
> The Stratix10 service layer and RCU drivers are useful only on
> Stratix10, so on ARMv8.  Compile testing the RCU driver on 32-bit ARM
> fails:
> 
>    drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback':
>    include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179'
>      declared with attribute error: FIELD_GET: type of reg too small for mask
>      _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>    ...
>    drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET'
>      priv->status.version = FIELD_GET(RSU_VERSION_MASK,
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reported-by: kernel test robot <lkp@intel.com>
> 
> ---
> 
> Fix for commit in:
> https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git
> ---
>   drivers/firmware/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 6a4e882e448d..08bd4d01fb04 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -206,7 +206,7 @@ config FW_CFG_SYSFS_CMDLINE
>   
>   config INTEL_STRATIX10_SERVICE
>   	tristate "Intel Stratix10 Service Layer"
> -	depends on ARCH_INTEL_SOCFPGA && HAVE_ARM_SMCCC
> +	depends on ARCH_INTEL_SOCFPGA && ARM64 && HAVE_ARM_SMCCC
>   	default n
>   	help
>   	  Intel Stratix10 service layer runs at privileged exception level,
> 
Acked-by: Richard Gong <richard.gong@linux.intel.com>

Regards,
Richard