Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750810AbWJGMdd (ORCPT ); Sat, 7 Oct 2006 08:33:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751050AbWJGMdd (ORCPT ); Sat, 7 Oct 2006 08:33:33 -0400 Received: from ozlabs.org ([203.10.76.45]:61851 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1750810AbWJGMdc (ORCPT ); Sat, 7 Oct 2006 08:33:32 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17703.40127.482493.417591@cargo.ozlabs.ibm.com> Date: Sat, 7 Oct 2006 22:25:35 +1000 From: Paul Mackerras To: Olaf Hering , Linus Torvalds , Benjamin Herrenschmidt , Stephen Rothwell , David Howells , Andrew Morton , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Dmitry Torokhov , Greg KH , David Brownell , Alan Stern Subject: Re: [PATCH] powerpc: fixup after irq changes In-Reply-To: <17702.62074.410366.433781@cargo.ozlabs.ibm.com> References: <20061002132116.2663d7a3.akpm@osdl.org> <20061002162049.17763.39576.stgit@warthog.cambridge.redhat.com> <20061002162053.17763.26032.stgit@warthog.cambridge.redhat.com> <18975.1160058127@warthog.cambridge.redhat.com> <20061006203434.GA7932@aepfle.de> <17702.62074.410366.433781@cargo.ozlabs.ibm.com> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 20 I wrote: > You also removed the regs argument from the get_irq functions. That > is a separate unrelated change, which I would want to think about for > a bit, because at least at one stage I had a use for that parameter. I remembered the use I had for it - for interrupt controllers that want to save away an old cpu priority value or similar. The ones that need to do that (xics and cell) either don't do it (xics :) or use a per-cpu array (cell). Also, we call get_irq from an interrupt handler for cascaded interrupts in some cases. So I have applied your patch and fixed the rejects. Thanks, Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/