Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Mar 2021 05:18:57 +0000
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Miklos Szeredi <mszeredi@redhat.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 03/18] ovl: stack miscattr ops
Message-ID: <YFrLwbf66HSsqCDE@zeniv-ca.linux.org.uk>
References: <20210322144916.137245-1-mszeredi@redhat.com>
 <20210322144916.137245-4-mszeredi@redhat.com>
 <YFrJp5I3nL1RriTL@zeniv-ca.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YFrJp5I3nL1RriTL@zeniv-ca.linux.org.uk>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Wed, Mar 24, 2021 at 05:09:59AM +0000, Al Viro wrote:
> On Mon, Mar 22, 2021 at 03:49:01PM +0100, Miklos Szeredi wrote:

> Umm...  No equivalents of
>         /*  
>          * Prevent copy up if immutable and has no CAP_LINUX_IMMUTABLE
>          * capability.
>          */ 
>         ret = -EPERM;
>         if (!ovl_has_upperdata(inode) && IS_IMMUTABLE(inode) &&
>             !capable(CAP_LINUX_IMMUTABLE))
>                 goto unlock;
> 

Nevermind, you take care of that in the caller...