Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3156pxf; Wed, 24 Mar 2021 18:57:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrg1SBwEC2RbsaK/oaBfFdfvTRHPZT0WcRKNLiAarfibHLlRA4pWLKUjdPtGC5ikrguH25 X-Received: by 2002:a05:6402:181a:: with SMTP id g26mr6438430edy.225.1616637455638; Wed, 24 Mar 2021 18:57:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616637455; cv=none; d=google.com; s=arc-20160816; b=Aydl4g0lkEFNuikoLznSkBAiCgu0nie+T3haHNgSr37etAEqHC+iUxKG3Zrr2MAq4t rnkxSIr2KA336nFjeIZJzFnKw6jWq9PLm3+pWb+9q6z79LBIxnkC1wsy4xYJ2hOUe+Fj +bXcy7qBgFvqq62vJzKhzvm3yaHMhWA3+v8As80rlEBOHqX/J6TlaUtMQUBBDJQWh7k9 Ayjyq3jO81pkiB3pW3TjeNnjq3OZ694XCNITzt10DJZWDbTq3zVeU1oa7b0OtBPLJ2ni mSjPu1Gn4kxMxB3VFTlcZbccuj967UGEi0xNv5YW6lIT0UTokdeADb78oJ4kzXNM8VQJ XP8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lB5j8vyiJX1Yue9bL01TlF6uxEe2YEqzs6luH0UzQR0=; b=gjPUMr76fnUqsoqfOc4e9nlmqqE7p0jwv/A8Opg31OaWGSjXZc4UFZ6Axl+H2uLI0N jsZi2KzTXHdGxXqqoI84aEx2v+eZqp/VH4FDQPViysbdU6cUj6uB7pKwKQyjyHLo5K1n 86jPTOl8gR7j5worppBHNY1tAkjOGrWqSLpkNHm0WsN6SYG3BoREBqIe4imkAwkLgLN8 hs4m7vTKNUmqJUpt5AwQd58aSupaKDEh5XLTWeyVg/EcyxMq36KiLoSbxfLsgkwyGFV4 R/LWZQsC/afSWR3juvpW6e7ULRxl/3a6v0nr6sY9Xz0OkebkObq3qZ0ONFzcFKOV2KpR v1vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="TwZ+u/Eo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka24si3061115ejc.64.2021.03.24.18.57.12; Wed, 24 Mar 2021 18:57:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="TwZ+u/Eo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231725AbhCXItq (ORCPT + 99 others); Wed, 24 Mar 2021 04:49:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:48702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231693AbhCXIte (ORCPT ); Wed, 24 Mar 2021 04:49:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 579CA619E5; Wed, 24 Mar 2021 08:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616575774; bh=HngmhS0wtasTKIvVa50RnFj6kvM+eDwLx+0Kof45b0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TwZ+u/Eov49iDQlwKutWzTCZaDPF58uo7n9jznAmUkGp5uNuh4nVby4iGhh1gCopw KNJ2KGIGqTvhSvrn3Htm69PLq1+g9mliAZPVpfo7WT7Rx4uYStrtEXExGYvVQn7Old ZPoVoToxXpqBjPnQPkAPY8LKPbdikzth7E8pUDNU= Date: Wed, 24 Mar 2021 09:46:22 +0100 From: Greg KH To: Kai Ye Cc: linux-accelerators@lists.ozlabs.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, zhangfei.gao@linaro.org, wangzhou1@hisilicon.com Subject: Re: [PATCH] uacce: fixup coding style Message-ID: References: <1616573515-38828-1-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1616573515-38828-1-git-send-email-yekai13@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 04:11:55PM +0800, Kai Ye wrote: > delete invalid and redundant variable initialization. Why is it "invalid"? Seems to just not be needed. And this isn't a coding style issue, your subject line is incorrect :( thanks, greg k-h