Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: rojay=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 24 Mar 2021 15:42:46 +0530
From:   rojay@codeaurora.org
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, mka@chromium.org,
        robh+dt@kernel.org, linux-serial@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Rajendra Nayak <rnayak@codeaurora.org>,
        akashast@codeaurora.org, msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V3 1/2] soc: qcom-geni-se: Cleanup the code to remove
 proxy votes
In-Reply-To: <YFm1Qvo3SuwJOino@kroah.com>
References: <20210322110429.14950-1-rojay@codeaurora.org>
 <20210322110429.14950-2-rojay@codeaurora.org> <YFm1Qvo3SuwJOino@kroah.com>
Message-ID: <f61210c135fdaa742cc4abdfcdebd8ab@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-03-23 15:00, Greg KH wrote:
> On Mon, Mar 22, 2021 at 04:34:28PM +0530, Roja Rani Yarubandi wrote:
>> This reverts commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect
>> support to fix earlycon crash")
>> 
>> ICC core and platforms drivers supports sync_state feature with
>> commit 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") which
>> ensures that the default ICC BW votes from the bootloader is not
>> removed until all it's consumers are probes.
>> 
>> The proxy votes were needed in case other QUP child drivers
>> I2C, SPI probes before UART, they can turn off the QUP-CORE clock
>> which is shared resources for all QUP driver, this causes unclocked
>> access to HW from earlycon.
>> 
>> Given above support from ICC there is no longer need to maintain
>> proxy votes on QUP-CORE ICC node from QUP wrapper driver for early
>> console usecase, the default votes won't be removed until real
>> console is probed.
>> 
>> Signed-off-by: Roja Rani Yarubandi <rojay@codeaurora.org>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> 
> Should this have a "Fixes:" tag, and also be cc: stable@vger.kernel.org
> so that it will be properly backported?
> 
> If so, please add and resend.
> 

Okay, will add and resend.

> thanks,
> 
> greg k-h