Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp32289pxf; Wed, 24 Mar 2021 20:01:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznwNwS+iR1XfyRCfOQ0ikv5MPAh1QpQopg/HY/x3w1y1iQbiCGzGb0aq6zNMrTGkMpUNb8 X-Received: by 2002:a17:907:68a:: with SMTP id wn10mr7056297ejb.551.1616641266494; Wed, 24 Mar 2021 20:01:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616641266; cv=none; d=google.com; s=arc-20160816; b=KkqWSzHdI2uYMoxBr6ByB724in+oqEBESzyKKVapY3UQG0AA1k10+KkRUHfygQ+JNT M6qCbXTHAAcuQJ1CI4cHIDF5/EOvHtlOM6rZwxmGQo4kGx5prdlOPhfgXmQf1jf5bmE/ dYwGeSyLci7yqol5PO5wsf60/HZS9Os5o7B8UFE9607kYtHIE32fWuk0pHbD7bbNblih VwCAVf3ZaQLIyx2VhB+KMdP7LdkZnMkRjQpNSC0d0IaioduqAvG03Ign51stBJTXGUUd 1vfGHzjBpGQISxI1GlUSbod6gUYDHmDseM1o34DiGyqEOOZXmLaNzZTu5uGLx9cOihIJ ACgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=PbP2qxBFx+JY+8mtFCtPm9GNc1rQAr3y9k6EopJyJik=; b=EdFkJJzuxUPSbjr9fDXNdZmKbQHkiS1DwSq3VcPf3z6xiYjtWUXFcQq3+z1sI6Mq3/ ZXiwzJeXoPQVjTF9p0FKVjb1liA6XndU5lrv4wSUVWuemFF9KU+aL/NPSTTojr5ptqku 5Ad9jYP4lTxlMUSLEwzpCgVZQoNB5owSH/gzZLcGo3t4PMUA8/yQQVlEQ2o2AiKJ2YP3 0R5ap1OjppHmTIkMLFPa9Vx98OdxAsSdmYYl3HI1vJ8S/dxSkAjpArYYyPPXSk25dZ1W K6BbsRIIXXO08ccbB8AVH65kbM8WixQTfiT2prpAMCmBNpNqBdcgIhEhNMkDZwgSHPG+ 1VwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si3091255edq.224.2021.03.24.20.00.44; Wed, 24 Mar 2021 20:01:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231814AbhCXMSW (ORCPT + 99 others); Wed, 24 Mar 2021 08:18:22 -0400 Received: from muru.com ([72.249.23.125]:46598 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233676AbhCXMSA (ORCPT ); Wed, 24 Mar 2021 08:18:00 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2601E8057; Wed, 24 Mar 2021 12:18:54 +0000 (UTC) Date: Wed, 24 Mar 2021 14:17:55 +0200 From: Tony Lindgren To: Hanna Hawa Cc: andy.shevchenko@gmail.com, haojian.zhuang@linaro.org, linus.walleij@linaro.org, dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, tgershi@amazon.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero Message-ID: References: <20210319152133.28705-1-hhhawa@amazon.com> <20210319152133.28705-4-hhhawa@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210319152133.28705-4-hhhawa@amazon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Hanna Hawa [700101 02:00]: > A System Error (SError, followed by kernel panic) was detected when > trying to print the supported pins in a pinctrl device which supports > multiple pins per register. This change fixes the pcs_pin_dbg_show() in > pinctrl-single driver when bits_per_mux is not zero. In addition move > offset calculation and pin offset in register to common function. Reviewed-by: Tony Lindgren