Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp33411pxf; Wed, 24 Mar 2021 20:03:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwB564AynsqkhaRkbA5bL0KVbir4bLU5LeGUXkmpMW/dicH46WgdblsXSM8SI2+oP9ShOhp X-Received: by 2002:a17:906:a1c5:: with SMTP id bx5mr7259600ejb.166.1616641390858; Wed, 24 Mar 2021 20:03:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616641390; cv=none; d=google.com; s=arc-20160816; b=bpdw7ehZFblzVQc3vfznHsfrfaLBhBzwNZSvlWpZ++PHv8ooVaO/fNK6Ll/kprtr04 5Lto9oUJf+5hv9rsnVC/ymyi6b0iHMolThIyLAhAMdwwfOvi46saPtLcUGgi4dmcBZmw Kfgpz7TlP02GpRy4HdFvqki0UwyHmaX/bacz6c4OEXKn/DyU5DG5xw4Yt/HO0FMqI5uZ O82BgRXUPUoDItAlv8/9oWM7rg4QPPzZnMfybZ6DMfGRFRQ2bCAya6p1SaX1IXWlXfmj Ne6rAsykmzr0C5/vOjNf9l6ESWHOrdr5lV/uYLAsyyJ5+6NQLax3zno9Cniy6KSq1Mwn 6BkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=ETqBMU69OiVYdMvCczpxH6iSVMFBbrvvC1c+Nearczk=; b=LUEZCFyfipd729gvMolec3XhAdbpatrRe+D/MhFwqS9p5NPIOcqzlnZh5kXFn7Ig6B JBrLMaxlTTQ7nN4H/L8ayT1UrsK4FyjwqkPiB6aweTUxYinIQ7ZxhB0qxE8tD6dLlWea Vvx8yeMlZ42BhcQKRl65TZv2uKpx5aNZqktGx0jQv9Ieqw/Uoynfz4ViaEHIbSRRVu+N 6gGaBxD3FnhuuhDcJ034trbJtU5mDMHkIrBTkcbWY/F5INKPtT+2yADj0L15jeTojD6F 3PIlqF4UotLBN1GusbkXfw69b7OQQY8ktHGIgESs6Kx2vYliRfEAlA1rr+5RyJH6o3J9 E0OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XypW53av; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rh9si3410419ejb.417.2021.03.24.20.02.47; Wed, 24 Mar 2021 20:03:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XypW53av; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233501AbhCXMd3 (ORCPT + 99 others); Wed, 24 Mar 2021 08:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232958AbhCXMdK (ORCPT ); Wed, 24 Mar 2021 08:33:10 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B0DFC061763 for ; Wed, 24 Mar 2021 05:33:10 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id g8so24559264lfv.12 for ; Wed, 24 Mar 2021 05:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ETqBMU69OiVYdMvCczpxH6iSVMFBbrvvC1c+Nearczk=; b=XypW53avmJ4g2E1pKslW36bigwllw9bzame6yU/kPt6JgEqriLu1KCO3Usk1g6d6pR hgWgRfZ4sFu3UglyoEsbQgwrdXnDY0ygCkG1ChPaSYVxVKMtr0aFVa8CZQiJVKTPdPns IsPOu6DtiVIbhj7laA0Wftj3art0pxx0RlAr0j7Hfbs9RoBlqXZFWgmuPaxCVHYSk5zZ az0nvJlTD9fgs0TngACy8f0K6oqGqnPkxFYDhAt8NnmKaCGo+rOazlGEoKNQBFMk73Vv gZhZk7sOA+P7zWKLfDJvfDIJg5LhW6ZQe/5Km5QSehqd76nQnNOFn6Svum3niOluJClx gpgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ETqBMU69OiVYdMvCczpxH6iSVMFBbrvvC1c+Nearczk=; b=Qt8qq2tc9w7NrxPIFyqpd1WKQtEiR/1TaQsBIS4ZUDQXdKAWt9yZKv6HS53dqOIuf7 wOEr21XYPWq886IR8ye09SgklZgcnz1F4Wyp5aSCc7l6/5RZkivc9LbhyEARU2bq9py/ zHjajBzlLRoAJb/4uYdecHKX5S9QlwEynyg+z6f74wswHaWHd6U9OXZxKr7+psweaWMa RZHaUXU0P6l0h42UGqpeBNsqbuxvVmqOUK1AlBAHO6ni5tX3ljt+530MJ31MzgTbKxyp vcuIBv307MLwuDI4UMgku2cqU/blnHMhA3tXjx7MGrkYmEifG9uv/lxuvnmAGFEAXQne q85Q== X-Gm-Message-State: AOAM532F1qKPEFf65g1ELTAehp+FxG8hAFmYu7gjSENfY2lBUpvIqjTF aB8d1Em049sXp3CvGhHsIX8= X-Received: by 2002:ac2:4826:: with SMTP id 6mr1830392lft.629.1616589188609; Wed, 24 Mar 2021 05:33:08 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-60.dynamic.spd-mgts.ru. [109.252.193.60]) by smtp.googlemail.com with ESMTPSA id h24sm295528ljg.77.2021.03.24.05.33.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 05:33:08 -0700 (PDT) Subject: Re: [PATCH v6] mm: cma: support sysfs To: Minchan Kim , Andrew Morton Cc: linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org References: <20210324010547.4134370-1-minchan@kernel.org> From: Dmitry Osipenko Message-ID: <3d90177b-e143-03b9-0f78-77740690266f@gmail.com> Date: Wed, 24 Mar 2021 15:33:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324010547.4134370-1-minchan@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 24.03.2021 04:05, Minchan Kim пишет: > +static struct kobject *cma_kobj_root; This should be a local variable. > +static struct kobj_type cma_ktype = { > + .release = cma_kobj_release, > + .sysfs_ops = &kobj_sysfs_ops, > + .default_groups = cma_groups I'd add a comma to the end, for consistency. > +};