Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show()
To:     Drew Fustini <drew@beagleboard.org>
CC:     <andy.shevchenko@gmail.com>, <tony@atomide.com>,
        <haojian.zhuang@linaro.org>, <linus.walleij@linaro.org>,
        <dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
        <talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
        <tgershi@amazon.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-omap@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20210319152133.28705-1-hhhawa@amazon.com>
 <20210322055631.GB392062@x1>
From:   "Hawa, Hanna" <hhhawa@amazon.com>
Message-ID: <ecaae08b-a8b7-ad36-1f71-af08c0cc6a88@amazon.com>
Date:   Wed, 24 Mar 2021 16:03:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210322055631.GB392062@x1>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/22/2021 7:56 AM, Drew Fustini wrote:
> I'm curious what SoC are you using?

I'm working on Amazon Annapurna Labs SoCs (based on ARM cortex 
processors). That include multiple pins controlled with same register.

> 
> It's good to know who has hardware to test bits_per_mux in the future.
> 
> I pay attention to pinctrl-single as that is the driver used for the TI
> AM3358 SoC used in a variety of BeagleBone boards.  It does not use
> bits_per_mux, but I can verify that this does not cause any regression
> for the AM3358 SoC:
> 
>    /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single# cat pins
>    registered pins: 142
>    pin 0 (PIN0) 0:? 44e10800 00000027 pinctrl-single
>    pin 1 (PIN1) 0:? 44e10804 00000027 pinctrl-single
>    pin 2 (PIN2) 0:? 44e10808 00000027 pinctrl-single
>    pin 3 (PIN3) 0:? 44e1080c 00000027 pinctrl-single
>    pin 4 (PIN4) 0:? 44e10810 00000027 pinctrl-single
>    pin 5 (PIN5) 0:? 44e10814 00000027 pinctrl-single
>    pin 6 (PIN6) 0:? 44e10818 00000027 pinctrl-single
>    pin 7 (PIN7) 0:? 44e1081c 00000027 pinctrl-single
>    pin 8 (PIN8) 22:gpio-96-127 44e10820 00000027 pinctrl-single
>    pin 9 (PIN9) 23:gpio-96-127 44e10824 00000037 pinctrl-single
>    pin 10 (PIN10) 26:gpio-96-127 44e10828 00000037 pinctrl-single
>    pin 11 (PIN11) 27:gpio-96-127 44e1082c 00000037 pinctrl-single
>    pin 12 (PIN12) 0:? 44e10830 00000037 pinctrl-single
>    <snip>
>    pin 140 (PIN140) 0:? 44e10a30 00000028 pinctrl-single
>    pin 141 (PIN141) 13:gpio-64-95 44e10a34 00000020 pinctrl-single
> 
> Reviewed-by: Drew Fustini<drew@beagleboard.org>

Thanks for review and verify the change.

Thanks,
Hanna

> 
> Thanks,
> Drew