Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Mar 2021 14:00:12 -0600
From:   Rob Herring <robh@kernel.org>
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     linux-kernel@vger.kernel.org,
        Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
        Sumera Priyadarsini <sylphrenadin@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        Frank Rowand <frowand.list@gmail.com>, kbuild-all@lists.01.org
Subject: Re: [PATCH] of: overlay: fix for_each_child.cocci warnings
Message-ID: <20210324200012.GA3528542@robh.at.kernel.org>
References: <alpine.DEB.2.22.394.2103221918450.2918@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2103221918450.2918@hadrien>
Precedence: bulk

On Mon, 22 Mar 2021 19:21:39 +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> Function "for_each_child_of_node" should have of_node_put() before goto.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> 
> Fixes: 82c2d81361ec ("coccinelle: iterators: Add for_each_child.cocci script")
> CC: Sumera Priyadarsini <sylphrenadin@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   812da4d39463a060738008a46cfc9f775e4bfcf6
> commit: 82c2d81361ecd142a54e84a9da1e287113314a4f coccinelle: iterators: Add for_each_child.cocci script
> :::::: branch date: 13 hours ago
> :::::: commit date: 5 months ago
> 
>  overlay.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -796,6 +796,7 @@ static int init_overlay_changeset(struct
>  		if (!fragment->target) {
>  			of_node_put(fragment->overlay);
>  			ret = -EINVAL;
> +			of_node_put(node);
>  			goto err_free_fragments;
>  		}
> 
> 
> 

Applied, thanks!