Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp47416pxf; Wed, 24 Mar 2021 20:33:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCfYH6l3FIC5BhSZH5ONfXYXcw2gwqzKGYF5bbBHUTB3NsLWY+kW2qSeVRjsJK9zeCt0QB X-Received: by 2002:a17:906:ccde:: with SMTP id ot30mr7113954ejb.550.1616643192538; Wed, 24 Mar 2021 20:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616643192; cv=none; d=google.com; s=arc-20160816; b=sr7HxPjxRkRFu3aEGwq9h5n8Mt+4+UwAQ++kZAt7reSDy8KIM5wcG19a2hYMJD3SF0 ZFMBuvaRdfSzzGLIMkilUOblO6eii+nd8woBd9kNZRiNi80Udwu5lU8wCV8oR+3LuGlt P61q/45KhVr+wwEw8rXbqb7o8b+zn8zVrsZXdEz981AnBuWEEKlTOdVPwUZGMldbqhjp XmI+Op76Yc5BJy6/btC2xmUUGE0Vpog6KUdMQmpGZTiMxJQO5R+4n6zaUXeIjAePaeBj dwl6l/Cn0ukmvbGAfOrlHKDMH0A7VAtL5oJGwFL/+wpi7pZbQg2KrckIma+6IB7MhJiV ereg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B8cQEyenOi6P1dFAPnRKGJMuEeOhjBSY7qxP2TEHV/o=; b=M9Hbu0wv5Jplb0AhNB83Oqher0NQGP4lYv87Hcajrwf1sTinUwkOGweGCf0biwwCdd m0efydjmUsHgJPN5NHM1NNl/So6m4rNn6KIAE86a1gKy3ClbOvyhbY0+r23rr8YfjjrL H5HzhVzM1S2CxT/VUrJ69zXCBZ1YH1p/JhDMwPVmu/NOwqffFh94gpXu6hmrUeXCVYiX SvZo3ru2tuw54+O8Li+GbrzZIrjZsbOneDzJt1liiluyGCqQmALXuwtvBuoZgP4aS5qK phxs6nXr4geeKEKPorYuHkg+Q8TfecYVBgVSpPj0qkWChC8uMRQdMbqIlEi8NscubsRD sZaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lj6TKx0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si3206886eja.264.2021.03.24.20.32.50; Wed, 24 Mar 2021 20:33:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lj6TKx0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235039AbhCXWKP (ORCPT + 99 others); Wed, 24 Mar 2021 18:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbhCXWJ7 (ORCPT ); Wed, 24 Mar 2021 18:09:59 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12726C0613DF for ; Wed, 24 Mar 2021 15:09:58 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id ot17-20020a17090b3b51b0290109c9ac3c34so1863838pjb.4 for ; Wed, 24 Mar 2021 15:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B8cQEyenOi6P1dFAPnRKGJMuEeOhjBSY7qxP2TEHV/o=; b=lj6TKx0RstOX0gCi1HsZbR1+i32sFs4YgJqVKDqJMqNl9P/JoBwbO2aTapvdiuP0d5 DUBzUDV4+r6jkyN2lpepyEX/HLGAKoApLDB3/ZFZ7jrzOOBwRnGPJi32vqtxploDw8q1 2xhcRg8iqo4Uoje6GvexvUjTkiOfFCXWqIfDCogdi6ZVYcl3Rv+mv39+uPPb1UJQ0bAq kPBthg+XX84Uy842vs62HsYZxS37Bz66dcdBGKhNLGpXt+qaGBIV9rPIPwlqOLM5a7s5 d2YGvho3F6mV31G/8IGY/TAGgIePMext3VqLwc+P0J3CSrRxDdUt2MZENf3sS5fMS1iY xCaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B8cQEyenOi6P1dFAPnRKGJMuEeOhjBSY7qxP2TEHV/o=; b=tDPUix0JW1M1qj6Nq3tBXdzTXCX0G4hMsXh4G0m/3CSta19BcTIPVEpGgpNEagkC2h GbW7H/gM0rXYldfrlPAvnSogFn7Q3WOvXRBq6bXUvsJJBhgJj3uhVCea4TYoPnSR2SJt 6hegfqfgeWommxbboFcQcmNbk1tdP4RfAQ6/U/6962Kloxkg6feJFUbpQsYaV4PXATvn 32+w00e/QOza1ijn5jQKR2ZZ8Ljl3u9KGo76/BIzfGGZctlxlsD99/3DSlGxDC64Zshh c5kQSnipxB3LuKO8RR+Ocha7T54bGLYSKsyBConhsouBUJ8dSK6nU9P9TZRzLk+iVbQv hTlw== X-Gm-Message-State: AOAM531vTcWXPoK9NVj8wibIdlTPNC46ZYufkf9qQiMqEY8UB6Lz1WtP t1qwaMMByAzNmOPuF2UpdXe/2A== X-Received: by 2002:a17:90a:ab91:: with SMTP id n17mr5749245pjq.4.1616623798097; Wed, 24 Mar 2021 15:09:58 -0700 (PDT) Received: from google.com ([2620:0:1008:10:7c86:15f3:3afd:ba78]) by smtp.gmail.com with ESMTPSA id d22sm3418535pjx.24.2021.03.24.15.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 15:09:57 -0700 (PDT) Date: Wed, 24 Mar 2021 15:09:53 -0700 From: Vipin Sharma To: Jacob Pan Cc: tj@kernel.org, mkoutny@suse.com, rdunlap@infradead.org, thomas.lendacky@amd.com, brijesh.singh@amd.com, jon.grimm@amd.com, eric.vantassell@amd.com, pbonzini@redhat.com, hannes@cmpxchg.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, corbet@lwn.net, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, gingell@google.com, rientjes@google.com, dionnaglaze@google.com, kvm@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jacob Pan Subject: Re: [Patch v3 1/2] cgroup: sev: Add misc cgroup controller Message-ID: References: <20210304231946.2766648-1-vipinsh@google.com> <20210304231946.2766648-2-vipinsh@google.com> <20210319142801.7dcce403@jacob-builder> <20210324091701.63c9ce8e@jacob-builder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324091701.63c9ce8e@jacob-builder> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 09:17:01AM -0700, Jacob Pan wrote: > I didn't mean the users of misc_cgroup will use css directly. I meant if I > want to use misc cgruop in ioasid.c, I have to do the following to avoid > undefined css: > #include > #include > > So it might be simpler if you do #include inside > misc_cgroup.h. Then in ioasid.c, I only need to do > #include . Sorry, I misunderstood the comment first time. I agree with you, I will add cgroup header file in the misc_cgroup.h after #ifdef CONFIG_CGROUP_MISC statement. Thanks Vipin