Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     Tyrel Datwyler <tyreld@linux.ibm.com>,
        james.bottomley@hansenpartnership.com
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        brking@linux.ibm.com, linux-scsi@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix EH race and MQ support
Date:   Wed, 24 Mar 2021 23:53:49 -0400
Message-Id: <161664413898.21300.158645434947164288.b4-ty@oracle.com>
In-Reply-To: <20210319205029.312969-1-tyreld@linux.ibm.com>
References: <20210319205029.312969-1-tyreld@linux.ibm.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by CH2PR05CA0053.namprd05.prod.outlook.com (2603:10b6:610:38::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.10 via Frontend Transport; Thu, 25 Mar 2021 03:53:58 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: df44e4f7-fccc-42a3-f313-08d8ef419ee7
X-MS-TrafficTypeDiagnostic: PH0PR10MB4774:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB47747BF7DD637A5723E8AF538E629@PH0PR10MB4774.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: W4M9DLdUS5UKmMBaqv5PLuGCqTxwmfA9nx+p6Qkk19uPtdvOSc8dlOWU5ADDFysbQT7TGPjP8Jsx5/7iXSmUOfeiedTjwzeiClNs4/G5fTfoHAkVTDYPGwbKyiAPYwIcwkaQP4x3B2mXCTgMVrxoLO5FcBmMv7uy9orHNKKfQi7wL8OBwD/PYmYFwHATTuj6pe1+VrD11i0M7lEphtEB4a3C7iZv08oop4tkv5OS9Fx8tE556uNv0GXg2Pamkn2E9qnOolpuVQ16yAjX+VTQc17IaOLgtm/hfEV7Z023ru5uFiqFv3kcvNe5knuLJjYQU7rF113j3QnZZgaEO3htWHyFvw8L53gZTs+UvKYzrsEx7zMpLrTKbWrHDq4U8QvK3pmMMu953bdK8+4/n4L2RZKU74ugFgF1eM/wYiUYyrdoqSCBfGmHCy389scjg1HaZbIlNuDuo7Dle59VpbvQpTy3m1N+Y71kFKIYdFYPn7Lm1moEGqAz5RCPVWjhpzAt3OniVVsMAM85QAf7TMTVGmweo8RkhJMlB/+rVZCqxD1t4+THHY8jh8svYjcEwoEbMUhCeSXRCqaqjcUtOUEaFSdugt3QX0TuaYEvs8m/riIFV1tRzj7hkHaY4F7r5fwsObJF/p2EWGcR2yxukCF9IZAgmZQnqhFjD0k6alrUE/M0ycq22zxvUdSANGk4ZAf1ysHtoSSaPjiwJoGwaqoy5znOXoQgpBZOh05l676Ol90=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(396003)(366004)(39860400002)(136003)(8676002)(4326008)(86362001)(103116003)(6666004)(36756003)(966005)(4744005)(38100700001)(8936002)(2616005)(2906002)(16526019)(186003)(66946007)(956004)(66556008)(26005)(316002)(52116002)(7696005)(83380400001)(66476007)(478600001)(5660300002)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UXFBVEtlQ1RYWWZCM3cxaG1FZXVZMkRHYjdFT2p6di9keDBDdDJ3SmpGZStP?=
 =?utf-8?B?SDd3cHpDSWdEczBhZURyeENLemoxYkViWTVLVlF1NEVoVHZnWWpubzh0NkUw?=
 =?utf-8?B?ejkydUh2ZU9zMTlJSzArQ0dLaGtGOXhSZDlNeUFpcXVQcjR4T0N4VittK2lD?=
 =?utf-8?B?aVFHZGFMUXZyeEZ3ZzNXTTRNSDJJVE9FazUzQzJoZVNKU05yVExFdFAvTUNS?=
 =?utf-8?B?M1NXZThBVHQ2YmlwcUdDc3RMOW85VzVMVURuRzRCU1hyTlhTUHpwRFdlQWRk?=
 =?utf-8?B?Q0V2RnV1QUtOV3lZb3Fqb0dZMnBIeEM2VmJpZkFNd0VLM09CWE4xbUZQNm9L?=
 =?utf-8?B?aU9ucFFzd0trYVZsRzdrTmRTcTh6UmRPT08zL0RKQzAwbkdXeGYrT1RrNElE?=
 =?utf-8?B?clEwVWpaVWhsMi85TkVhaGdHalBSVmp0TUR0cEcxeHdsMWpWUFV0ZFJDTDUr?=
 =?utf-8?B?UnIwZm94SjZTR0g5Yk9qYmM0WlE1dC8vWlUzTTdCRWQ4S3lLd1JqelAvWERQ?=
 =?utf-8?B?RFFZelZLNVBJNzBxUHJ6U3F2SHRhR2dVWHh2d013b05IYi9pcEdPMW85cmhi?=
 =?utf-8?B?VXBzZngrczRGUnJOSGhGRmlwY0JnZldXNUoxWHRZSTQ5aU9UQWtZZUdTQnlG?=
 =?utf-8?B?R0xqK0haL3JBN2t4MHJNRjRhRTFQWEF2K0w5UkJialpHaXovTHo1a0JSZFZX?=
 =?utf-8?B?VkoxK0NKNW05NkNMdkRIYVo0Q3lad0N0V0NOanJaZmRja0crcEhSL2x0QXBy?=
 =?utf-8?B?R2lSVktBcXkwU3dvWjFMZXVNRFdCMjkvVy8rUXRFRXpIOUlrcEUvLzBQYWNF?=
 =?utf-8?B?RGh6RktRdmtiMjB6aVA5dUMvZHRrYXVZdHBoclhFaGg3dTBPbTBEL1NsMTlF?=
 =?utf-8?B?VEVRT1lYU1NCL1dueTBpU1JzcTBFZjkzbVpnMlhuOVprckU2b3Nud09nekND?=
 =?utf-8?B?TGxRQUg0WW1qNERLQ2R0RmsrTFFIUzdYZ3l5VGRCVkpKWWNGK0RMSzdKaXRJ?=
 =?utf-8?B?RWpySTlnQ3VoL0gvSWwvR1orZ05uMFlMMmdxV0kwUHlDREZtaHZTanVjUmxu?=
 =?utf-8?B?RkhkMFBIdUp0cFU1Q1p3NHAvR1RiRmZjYmRmc0Z3ZzJOR3h3aWY2NUI1R0lk?=
 =?utf-8?B?em9MRmJXK05sSHNnVGRtc09VYkljMzhjYnhGaFVwZWJGTlN2MFBCMnlIV0k3?=
 =?utf-8?B?NnBnMnFtWFVmU00wRjZubHM4SWV6NFg0OFRCYlUzRFRxUE9aOWRwaE1OM3RX?=
 =?utf-8?B?NDFQU3hqQ3crNC9PdDJnbEw1VkY1cmEyNGdwQmNqMjFERXI0ekx3NEo1SGZk?=
 =?utf-8?B?M3dmU0pvQUxZYVRtMzN5cldmaUlXWWhRNmJPa2U4ZzRLRjE5d3daRDRZYk9G?=
 =?utf-8?B?aDQ0VWUvRDlERDJIWE9zaUgvWjljeldhamNuSE5qbEgySjZHSWw4S002Nkdk?=
 =?utf-8?B?TjhvaWFjc1QxVmdnalJNeWd4NEd5Z1pzem9Lblp3WitqeDdvQ09URHQ1OFY1?=
 =?utf-8?B?aEtWWjd0cHdNdXlVZVNBSGhyaVZ5V0xtN28zZUVIeGlqeDBhd016dTJPQ1gw?=
 =?utf-8?B?VG42UVQ3dXRqUTRlQmFJRGtveWxMdHAwV1FTZWdqQjdnK2VjRkRVbEM1clcy?=
 =?utf-8?B?YnZWNFdFK0pCbHlkK2dJbHhaNFJwMXd5SGlueUdyS245bGNnVHg5WGhFQllo?=
 =?utf-8?B?TFB3VTNDZ3U0dCt0cHRtemhTVG0wWE4xM01Ia1l0RlFHaGd3R2tkNEJieS9x?=
 =?utf-8?Q?nyRzqB0O7f8dhI3kSn+MKPOOgwUG8xTBI+M2oku?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df44e4f7-fccc-42a3-f313-08d8ef419ee7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 03:53:59.2890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zVSaBMMgKWMmKyO4v/CUd2SaXvtUzLWQGpSr9nU5JmewIsOouZ6n70VrUM366c7IKDIp6jQAQGLije5xaj2AK6fuCe/KUMZ+0MXOuxTKVEU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4774
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103250026
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501
 spamscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103250026
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 19 Mar 2021 14:50:27 -0600, Tyrel Datwyler wrote:

> Changes to the locking pattern protecting the event lists and handling of scsi
> command completion introduced a race where an ouststanding command that EH is
> waiting ifor to complete is no longer identifiable by being on the sent list, but
> instead as a command that is not on the free list. This is a result of moving
> commands to be completed off the sent list to a private list to be completed
> outside the list lock.
> 
> [...]

Applied to 5.12/scsi-fixes, thanks!

[1/2] ibmvfc: fix potential race in ibmvfc_wait_for_ops
      https://git.kernel.org/mkp/scsi/c/8b1c9b202549
[2/2] ibmvfc: make ibmvfc_wait_for_ops MQ aware
      https://git.kernel.org/mkp/scsi/c/62fc2661482b

-- 
Martin K. Petersen	Oracle Linux Engineering