Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp182487pxf; Thu, 25 Mar 2021 01:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfmQGmCQwZUoMDNijTzt9OL4Blpm9U5jSucKb/AdBKEREWky8B+H0CTc3ckKA0cfI+33TV X-Received: by 2002:a17:906:7d7:: with SMTP id m23mr8156831ejc.205.1616660313379; Thu, 25 Mar 2021 01:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616660313; cv=none; d=google.com; s=arc-20160816; b=WHT5J0ooGN5i5cwkhv8uMzIkosggrUAypCQ2u913SHpiPBwq683bg5tvwpMniHfhIP bI//COrCd/7CAFtN0OqQUO9tR720ZUHQPXWpH6DXMIYk2DoqhU/HJliINZqPrIDwkQpI GZPA1xxlIy1kCmEcki7L+vNd4EserzBzybJl8QMJqzVH89GH08wU1YPoA331MVh2xpCJ 2PWqCEofKh/mYabITLoHMCce4qtecltJ4At77itChq7bm4KjfnbDpJ2KWgAPo/By1CCr j/1RME+q6DTKZeY1nVjEGJ5D8TCU8esFKox0vS/e1i4HKmT804jIFYcw3pIkQC8tzbO8 XlLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/exH9O9awcWsxCz7+eapTVCjP1xnjzd++2TmK3g0wUA=; b=Ye0aseXCCMwbyALkbjXbzF44IR2vJMnWw6ZIfBPKPem36gMKKMvorA6TctdG8p8Amk z7B6lHxYMU/ZRS9G86AKVYKG7zuJkIAo5uNeBxVGNVSMQQpT27kX/66Ua641u3BsJ25U tD5QocfSmL6wdXwgRt5jn/HyRNL4NLCUSCCWUOoXftUELEhi3/JIeE51ECtpJD+hmsu7 R3lRWt9qQ6A4T3T+AWeRSJlIgKgsCvpdoCC/3x+RhMqxBwSgQhQLrXvqD6Xecx/Le5c5 ceUhCBmVQgK6kG/kr9F/a109hDZa0xmkpRC5FCNoUofnXvNovHYhXOOD6gL7syteeBbl Lt+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mza4LLBS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si3608202edb.348.2021.03.25.01.17.54; Thu, 25 Mar 2021 01:18:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mza4LLBS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbhCYIQo (ORCPT + 99 others); Thu, 25 Mar 2021 04:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbhCYIQY (ORCPT ); Thu, 25 Mar 2021 04:16:24 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FE4C06174A; Thu, 25 Mar 2021 01:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/exH9O9awcWsxCz7+eapTVCjP1xnjzd++2TmK3g0wUA=; b=mza4LLBSMR5tgg00tK6/RqwQry EAWd+m3DmQ5LsHRZKpQcVroIj4hHPKMXZeiDU6H8WaOSWgA3Px6N+76itUWRjbryxa4/LU5SIjTi4 kvOAg5i2hzYGoVV88qRszX0+ZYbQV2Oj460JUXXQc/Nf4PqndcOxoEzXahqHyolGihggvuIyBmkjc vdRP9Kv8oS1sskhHLDQ7mVC4ucvxbxolI7CPsrMYx3Ud13XsNnHJHs9F7CaRYGF9XinZCMZrBb6eO XWEvbq7mPzOiPd92WTnq8e0rKsrRKASUqwZ71WJTXp8wY5EldPpCxwS8yjlommcB3dE2wgohUPhsp vQJgoTpQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lPL9n-00CWsM-Ov; Thu, 25 Mar 2021 08:16:05 +0000 Date: Thu, 25 Mar 2021 08:15:55 +0000 From: Christoph Hellwig To: Dan Williams Cc: linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, ira.weiny@intel.com, vishal.l.verma@intel.com, alison.schofield@intel.com, ben.widawsky@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] cxl/mem: Introduce 'struct cxl_regs' Message-ID: <20210325081555.GA2983117@infradead.org> References: <161662142382.1723715.5934723983022398253.stgit@dwillia2-desk3.amr.corp.intel.com> <161662143530.1723715.15800475088422813585.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161662143530.1723715.15800475088422813585.stgit@dwillia2-desk3.amr.corp.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 02:30:35PM -0700, Dan Williams wrote: > In preparation for common register mapping facility, introduce a generic > container, 'struct cxl_regs', for CXL device register and later > component register block base pointers. Some CXL device types implement > both. The code looks like complete gibberish to me with a struct of a union of a struct declaring members in a macro. This needs a much more detailed explanation and rationale.