Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp187454pxf; Thu, 25 Mar 2021 01:26:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytTJwTsRzkwxDU2d/5ttSjsql9OJBjHe7W44JAFtNkU1b74az8p5WBAcW75j5STQg+EhVa X-Received: by 2002:a17:906:14d4:: with SMTP id y20mr8091088ejc.190.1616660817799; Thu, 25 Mar 2021 01:26:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616660817; cv=none; d=google.com; s=arc-20160816; b=FjM2lsqfC4RSuKy9KIpbVqB5cwBOwcX0i8s+WNGYHz5A9UczUY0pSZk8r+wzko8WRA NWUBmIQB+Kxw8zL+S2k1XTILdsCi0/YYRfznYX49MqQkRyXIBhX/lBlO9rQ1knjCGAx9 bOv2qhVWNeulkf7nEQ9s/IznUaCZbjV2tsPSir+em/9ILxix3UCzeIBpK6ipSDagd0Y3 pUAAQgrWe0YXEk9sZ1dBtvQRWt1qEtxD1ZBFwOqz/M7D1W3xVWSxi6iIC7PzrtfmeyjL 21JKlqNrc55HYp2b/0k8Il0uP3nNtX67ofvcZqaAaUT5T/maWyHITdkwKoy6U701FiDy V/mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=MM401JBaRTTCCJL9EaHzR6NPRIf5hOBSDc/cL6Z5a90=; b=LhJoStCjnOb+LGj0XVEFShWrBcJWBtVH0fc4K6lLcCu6C2jsqkYeyqUtSin9zV/IRv II7ErV/TTorw07DxzefKcRw2QIhfkejqpKXhBURlFS0xA4tEHzBk/TKZcacwj2UZ1nML t3jMpC2Qh7siD9a9XDPeJjO9yrU3j7OYKIE1bZJgCxM37WtAurStykrOaqQNWjo+sFDw RYB2sARVXm8rnY38IfG/yhN+wHM3MJJxsdUoCRj0t73AdLaGvxtqLU8kkumYa8hi2jjE mLu9IY9J3U5FmBWVIdfGLJWas1A7hqtlgHhY+/PowtJlG+glrswof+eXIVURro6Q+zox vKuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u4si3884222ejr.169.2021.03.25.01.26.35; Thu, 25 Mar 2021 01:26:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229624AbhCYIXq (ORCPT + 99 others); Thu, 25 Mar 2021 04:23:46 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:33732 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbhCYIXR (ORCPT ); Thu, 25 Mar 2021 04:23:17 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R241e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UTFuKJG_1616660584; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UTFuKJG_1616660584) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Mar 2021 16:23:13 +0800 From: Jiapeng Chong To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] media: mxl692: remove impossible condition Date: Thu, 25 Mar 2021 16:23:03 +0800 Message-Id: <1616660583-122448-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coverity warning: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "opcode >= 0". Signed-off-by: Jiapeng Chong --- drivers/media/dvb-frontends/mxl692.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/mxl692.c b/drivers/media/dvb-frontends/mxl692.c index 86af831..8303064 100644 --- a/drivers/media/dvb-frontends/mxl692.c +++ b/drivers/media/dvb-frontends/mxl692.c @@ -377,7 +377,7 @@ static int mxl692_memread(struct mxl692_dev *dev, u32 addr, static const char *mxl692_opcode_string(u8 opcode) { - if (opcode >= 0 && opcode <= MXL_EAGLE_OPCODE_INTERNAL) + if (opcode <= MXL_EAGLE_OPCODE_INTERNAL) return MXL_EAGLE_OPCODE_STRING[opcode]; return "invalid opcode"; -- 1.8.3.1