Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp196300pxf; Thu, 25 Mar 2021 01:44:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/2IgUMLMho6mqO6oR4KDzpkCka0SQKfaJiH2rMJjMdN8cIeLQ9wMoHFcm9lppmbofrOUI X-Received: by 2002:a05:6402:304b:: with SMTP id bu11mr7570063edb.157.1616661843798; Thu, 25 Mar 2021 01:44:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616661843; cv=none; d=google.com; s=arc-20160816; b=JD9jeBROGzvQyIH37t49wTq+ZaDWbsqDAwpzQjVnZmheeXL+7KYfrcL/6C3Zz8Jm+U qu80a2uAjf+2nuZCNlBSjgG1Dq0KjQrOfSX5KHtw8xpSuvtuuMMVqasNV0DiH72Bpx7x FkApu8MT/hgsWKzme7mLp43SNEg5zdr6hVPzj5MilXdowkekvnevt8zYG1fpHvYlPnlW bjOoAt+jU55kL97hVXd8mB/NdLERUW1M66QuenLOYD/B1yBkFdzn99m0glSCFESnV9kc pmw9eF0mHkcX3nXGojL6AS7ndqz80DRzLoJEfHke8BCbi1x+6C0oT0kb00ljgFmW27cw +ipA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=9JpMbufc15fEgcXCPIcZh/TTQUwoRzA89sCw/7PwM6I=; b=Vp07Lmx1snRGpk6f3X4u7aoZE4l9BqV4PRJYwTVg5Iasy0hQepVBGwpEd8NRa0X4tP 6glSHo6TMiVkaCs5/uNcwhliiHnrzo2BeJRJImXAyefcVFkrof4wGDL3JTpGKDGMHpwq jguJVj3FrVlKuJoacI17pRrotr+WiyxR+Q4JIe79kpiGIUSGzQK0tqRC4zsKi5iThRb5 Gx1PoNL1GGYTsev0egLcqu6UC8KVd8982S2hZ5ldi0Utr1IJ9g+p+4Vb0JwOl8N5zoDM YfrEkRcJmCTDp2yxxEYUcVIYitC3l0oY2Gf7ctl5ifZ2VUO23HARUAxlztkwPSaHhC1U keHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b15si3926280edz.247.2021.03.25.01.43.40; Thu, 25 Mar 2021 01:44:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229461AbhCYIk2 (ORCPT + 99 others); Thu, 25 Mar 2021 04:40:28 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:40250 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbhCYIkH (ORCPT ); Thu, 25 Mar 2021 04:40:07 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R791e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UTFqzCb_1616661599; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UTFqzCb_1616661599) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Mar 2021 16:40:05 +0800 From: Jiapeng Chong To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH v2] media: mxl692: remove impossible condition Date: Thu, 25 Mar 2021 16:39:56 +0800 Message-Id: <1616661596-11886-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coverity warning: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "opcode >= 0". Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: - Make the commit message more clearer. drivers/media/dvb-frontends/mxl692.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/mxl692.c b/drivers/media/dvb-frontends/mxl692.c index 86af831..8303064 100644 --- a/drivers/media/dvb-frontends/mxl692.c +++ b/drivers/media/dvb-frontends/mxl692.c @@ -377,7 +377,7 @@ static int mxl692_memread(struct mxl692_dev *dev, u32 addr, static const char *mxl692_opcode_string(u8 opcode) { - if (opcode >= 0 && opcode <= MXL_EAGLE_OPCODE_INTERNAL) + if (opcode <= MXL_EAGLE_OPCODE_INTERNAL) return MXL_EAGLE_OPCODE_STRING[opcode]; return "invalid opcode"; -- 1.8.3.1