Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp267819pxf; Thu, 25 Mar 2021 03:46:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJsMubGvJedHj6OZDxF6HMR2Kql2EhWCCh874n0agckiyWUJr1oYTWbSDTJ1wfwMq3/GF/ X-Received: by 2002:aa7:dd4d:: with SMTP id o13mr8545879edw.53.1616669167912; Thu, 25 Mar 2021 03:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616669167; cv=none; d=google.com; s=arc-20160816; b=qYpdeOc2HXgJCX/ZKLM6oDLmE7SsYLM9aQnJALHzkcNdioIIOgi9jlEGt8hymwAXET 57SdxnXL+JlB7m90S1V+HOv00hzkEFS1FgPWXQ1VEQHkrMK9AYQgzAVJ+dgt+lBOGQTs wjsltFOAPXNuwD8P9cpN9fz9Jeoej5CcJ3KRAGC0/0gY+z+Zi53//4H9SWRXhAmYJbhv hItHu949wscWmojLdoF1WL3/KVXkd3rGWDR90n+dv2kOW/YnFckZsJ+bEXYitEsSGUi+ Vh5oOKVcuhvWmEUnY2Sqhy/fipjKdOJxWE4is1x7HZW3zadqFO77IEL9QFPGg+acEsgd tizQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=MZjis3vrfNS4o0432qm7e5nhATdqsIWVgffv/njY2mk=; b=jIdRkKbSLx6Ej0EES+L/0FNKGHvQaytt+fkxDueCOeMMF9nYXKvSrKtkIigWmNQ6hf veAUo3uWZrW5ItMcf4yH0PhJ1GD2Gter6rKXOAmqaqDYlqx/hAGtqkH//IYaDI0xg7Bk m7SrR8Dtul9Ybmo0o6U1b8dcqBnrpqugJ23ZBKbvLNh9eBjAcBjZb6/Ti7rOImUQAypk qdPb60zPxFjdn8qmGBP6qtGaIM4n+TtB+rApXZH0ckc0NXcaSlCoU4kOe0q5CAa4bZop fVqw4RTEzAdHwVd/m9YRWMosQw4CBjvR8trLyusA8AQK50EE0vgOZTIZqEie8gnlh3Bv Mq9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ukk2S4Qy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si3931508ejd.376.2021.03.25.03.45.43; Thu, 25 Mar 2021 03:46:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ukk2S4Qy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbhCYKoq (ORCPT + 99 others); Thu, 25 Mar 2021 06:44:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbhCYKog (ORCPT ); Thu, 25 Mar 2021 06:44:36 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83E50C06174A; Thu, 25 Mar 2021 03:44:32 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id v4so1735332wrp.13; Thu, 25 Mar 2021 03:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MZjis3vrfNS4o0432qm7e5nhATdqsIWVgffv/njY2mk=; b=Ukk2S4Qydfdr4xZ5yBY5upwmcg/QvDRZdymH/Xt/x4VXYfaLh7NpAne0dJfIbJx/Fy 6G+k0D4Pbc0ZnfAUleUBNL1FMyWKcUFxrLrWUBJjiofGkCnLJWROhA/600JMJGmQlbm7 VhuCjiAlTXFdKp4FrJ1lutY93b/hia2CGVfQ1gxV4wTffOIkKDoM7z5yXAJqjN3Mnxvx jCKWpSMxycVpKciAKIEuLDrSZgfnJd9CdBbDP7HwsnrFG/5v9KYdpusGe1A4b7gAQ5Iz e3QxX9fUTxACR9wyM1pU6OW4gOHTLU7wTmZP864zP44R9FpPl3Y1OzNR/W//4fP2ciir B50w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MZjis3vrfNS4o0432qm7e5nhATdqsIWVgffv/njY2mk=; b=qZF8LEUHcAee4BLPuP1HiebecMKSywLTd4GH4R81BWwkM4xUkjndIhAL8sCLyE6E9I hrzVbSsxn7507yjZ36+A/QVNpsG83Y4Zab5zRImBh6CEqtpKpm3g9jBeJlL+B0+lu6SD fRChclvJ9PfwNZ5IuNmnwNbSfyxKG8P2JoZKeLFso8PgW8dNMS0+fE7Cdb54jkD1PRpk mpGrAW5jcURE8Ky+ZiD6YnRxBUTtRq/cr3vH565UZL29CUeNs6okUDAS8lbWqJ42ek5z yExJyeKT3MVqVGOClAB/6oim0KWtpXx1X1aN6pkNbVNucJeTfNOs5AjVk/pH3g5g9smP Nwag== X-Gm-Message-State: AOAM532Z6XzRH0L5zg/52eHwhTR1VgQunMwcOH7+46nf6zYxBlk+1jiw 5Ct/lTh4IRFtPSeSlhPx1gXsDX7aC5vbt5VuFRyxnQ90 X-Received: by 2002:adf:f2c3:: with SMTP id d3mr8320379wrp.380.1616669071289; Thu, 25 Mar 2021 03:44:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sunil Kovvuri Date: Thu, 25 Mar 2021 16:14:20 +0530 Message-ID: Subject: Re: [net-next PATCH 0/8] configuration support for switch headers & phy To: Andrew Lunn Cc: Hariprasad Kelam , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "davem@davemloft.net" , Sunil Kovvuri Goutham , Linu Cherian , Geethasowjanya Akula , Jerin Jacob Kollanukkaran , Subbaraya Sundeep Bhatta Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > Hi Hariprasad > > > > > > Private flags sound very wrong here. I would expect to see some integration > > > between the switchdev/DSA driver and the MAC driver. > > > Please show how this works in combination with drivers/net/dsa/mv88e6xxx > > > or drivers/net/ethernet/marvell/prestera. > > > > > Octeontx2 silicon supports NPC (network parser and cam) unit , through which packet parsing and packet classification is achieved. > > Packet parsing extracting different fields from each layer. > > DMAC + SMAC --> LA > > VLAN ID --> LB > > SIP + DIP --> LC > > TCP SPORT + DPORT --> LD > > And packet classification is achieved through flow identification in key extraction and mcam search key . User can install mcam rules > > With action as > > forward packet to PF and to receive queue 0 > > forward packet to VF and with as RSS ( Receive side scaling) > > drop the packet > > etc.. > > > > Now with switch header ( EDSA /FDSA) and HIGIG2 appended to regular packet , NPC can not parse these > > Ingress packets as these headers does not have fixed headers. To achieve this Special PKIND( port kind) is allocated in hardware > > which will help NPC to parse the packets. > > > > For example incase of EDSA 8 byte header which is placed right after SMAC , special PKIND reserved for EDSA helps NPC to > > Identify the input packet is EDSA . Such that NPC can extract fields in this header and forward to > > Parse rest of the headers. > > > > Same is the case with higig2 header where 16 bytes header is placed at start of the packet. > > > > In this case private flags helps user to configure interface in EDSA/FDSA or HIGIG2. Such that special > > PKIND reserved for that header are assigned to the interface. The scope of the patch series is how > > User can configure interface mode as switch header(HIGIG2/EDSA etc) .In our case no DSA logical > > Ports are created as these headers can be stripped by NPC. > > So you completely skipped how this works with mv88e6xxx or > prestera. If you need this private flag for some out of mainline > Marvell SDK, it is very unlikely to be accepted. > > Andrew What we are trying to do here has no dependency on DSA drivers and neither impacts that functionality. Here we are just notifying the HW to parse the packets properly. Thanks, Sunil.