Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 5/7] iommu/amd: Add support for Guest IO protection
To:     Joerg Roedel <joro@8bytes.org>
Cc:     linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
        Jon.Grimm@amd.com, Wei.Huang2@amd.com
References: <20210312090411.6030-1-suravee.suthikulpanit@amd.com>
 <20210312090411.6030-6-suravee.suthikulpanit@amd.com>
 <YFNyUZg0JAgBLWwX@8bytes.org>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Message-ID: <ac209589-f351-d8a9-e47c-0ae622fd0b13@amd.com>
Date:   Thu, 25 Mar 2021 20:06:05 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.0
In-Reply-To: <YFNyUZg0JAgBLWwX@8bytes.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Suravees-MacBook-Pro.local (124.122.77.106) by KL1PR06CA0063.apcprd06.prod.outlook.com (2603:1096:802:14::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.28 via Frontend Transport; Thu, 25 Mar 2021 13:06:13 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 6b690cc3-7f25-4ac8-9f13-08d8ef8ec5aa
X-MS-TrafficTypeDiagnostic: BYAPR12MB2597:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR12MB2597ECE954E86F272E208B64F3629@BYAPR12MB2597.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9dQdiUeTB8Hmsm9kivX/GuTi8r6VFyyLEYyi6rHrRJvMFNPbMMEbCU+Zcdrs+EHQ6P+hWGa5zCuyRT2RLYglt5AxxPd3LN32KAoM4dwUbISYQIwegIXVxg2L9AUSLUaRrGoqbdZRuJkYcE2wSqjhEnK753MZvf7yfTbdx6Z5EndoEV6t3gU46wdpjj7ofmHWCP6YCo+AJlBPxaTG/S/oL6boNK0GoXNVy2Dw6BWxR1WuP1EI3iULqox8x1YdmbfSiIlKPtJ4jjjmvO1dD6lCklf5W8LL52G/JHGr0+68lN/GEQiIxasnlGGBV4Z51PrNeQ4cr5qxepOKpYLywJxqCGYEVJpJp61CZ36wvp2CyQ2jti8VMGqXi1h1pbtJsMCZ4cxgxrU+gy9q2am+9Ms87N8js+2FNveOz37QvgjYgT5dxcxB1j1k27TkJFlT7FJxz/wqOD5yjQKfY8XoEBOISDEh/+vpcsAAW0hvP2r4u9x2f6MYiL6W1vtaklZL+CF+GKcRaxHrnLNfzam4b2iJVvNVC7wsConzuV/BRInSECZsygd+k5nOrwiugdqvhGHd897bgNiyk3ro8AEqz8qbghDnSlWDebOg8sAxkwn19hBwhxKhMllb/hUejIX8rFl9XkznLYpq/LS49Zu3LydJ2Nj4XVZ+GdijmUaIbmwMHEPz6KGUEfTiXHJv683PBGY3OmGoUpz7mumoBpP0ZDN0GDu4/5hKf8LNH4HXjZmVEuE=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB4597.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(366004)(346002)(136003)(186003)(16526019)(6916009)(6512007)(31696002)(26005)(38100700001)(66946007)(316002)(66556008)(66476007)(52116002)(6506007)(36756003)(4326008)(6486002)(83380400001)(53546011)(5660300002)(8676002)(8936002)(478600001)(956004)(2616005)(44832011)(86362001)(2906002)(6666004)(4744005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MDFvRHlIdFZiaGJhaDBhU1puc1FYdVhhUHhQNHlMdWdIKzZjVHBHUFo5elEw?=
 =?utf-8?B?bXdsZDQ3TUcxZzdTNXV2RmkrSjg4ZlZXR1F1MWFNTzdweC91QlU0Tkl6aXRL?=
 =?utf-8?B?WkJNbzlSaktrOHhsMzByeUtzS01kdE91ZVA2aHQzeEM2RlZudmhoL0RkZkc5?=
 =?utf-8?B?TmRhSi82ZWdSTE9iNmVPR2o0WEREY1ZkSTRYY3hyTGNXL0s1YjBpRXdZNkpT?=
 =?utf-8?B?dU5HMTNwSWtKM1NnVXpvQWs0ajBXNlFNYnY0WFNyVVhXQVp3Ky8vR2kzazBC?=
 =?utf-8?B?MHpBMk5CdVJISE1LVHJwQi81ZmEzWEczaVprZTNCYTlqU2swSzJNaXhXQ0NU?=
 =?utf-8?B?bmg3YUl4bTJCZU15ODl2czZtaHg3bmtwQmQyL1BNQW5xNmYyL1JvQWg2N2Vp?=
 =?utf-8?B?QzlYdW9KS0lYT2hxS1Ntd0x4aXpJM2ExakNtU1I3ZlF6ckhyVG1MVkw3emxs?=
 =?utf-8?B?cVhmWkQxV3Q3RE16MWloTVFLT2hweUNJQUk4RW1NTHpoMjJ1MU10SERVVTJO?=
 =?utf-8?B?VDRqVGFWaTdRZ2RtZW9TQWRqMll5eW5tcFVDMEIrbXlmQm5KWUJOREtwUVdT?=
 =?utf-8?B?TTd0NklTTUhZZjlHK0ZNMFpPQmVFRU9FOUlmVDN0QlRIOUJiR2FIUFlGQzBP?=
 =?utf-8?B?bmduZnFjQ3pEUlFobEZkVjkvVnRPeVRHaU5KRVcvTWFmVVJSd01mbkVXUDVE?=
 =?utf-8?B?NUVqY0g0OEo1MmlORG1Ndlh6Y3NJK1JweHY5enJNdTNRcTNtYVk0VkYvSFd3?=
 =?utf-8?B?MHRBWWZCZlg5M3BMNXpSMmM5bC9waGUyaEFsR2ZyYk1yakszVWdXMVRBT3I1?=
 =?utf-8?B?OXQzMVFCS1dRUmlKZms1dUJwMlJJVi9rbFAwdk5TTlZGbDhPMmFZSGdHdDc3?=
 =?utf-8?B?M24xaVFCSjQ1S1lXUlh2Rkg3UEIrNjBNSEdEM1ErQkUvUnRmWDFpY0N5d2hU?=
 =?utf-8?B?TXR1aEZEaS9sdnliZWp2ckVFNjV2K1NuMXdPbDBJS2VjZ1hRSXB4RU9ud1hj?=
 =?utf-8?B?MGVXa0hmaGNyYm9rYkNqb2lHbTZXeEthVnhxMjNieENhZ2oxa1RhaldBTm9h?=
 =?utf-8?B?WGhRUFNJK1N3UVJnOWcyRDZ3MUZjUzZZbnBSNlBJSTFISGRkYzVmMC83dGdp?=
 =?utf-8?B?bWhaREZQcEZKQTRFMU9HTGFDMUI2c2VxZmFwYThvVE5jQTJHdWY3Q0FTbXM0?=
 =?utf-8?B?VmUzNXcvZStCbEtmcHdZbkdVNzdhTjJQeUpmOC9ZZnpPaEphQmtPcUVJREo3?=
 =?utf-8?B?Uk83S2U5YUI2cmZmZVBtWVFaWHpYaktaWUZlUEZHVThlQ2xFSWhYWDg1Q1l2?=
 =?utf-8?B?L1VYRDhrSU5WL1d1aHV4bmJQT0RoTE1nT1QrNjc3ZllDMVlVMFMwMXRZZmFL?=
 =?utf-8?B?VnNxdDdNMHVpUWQvYkdmeVYxMG1wMFRPcDlDaXZRVFUzV3lZN2J5dXBUSEIx?=
 =?utf-8?B?WWFjaW1wQmJjWGhoZFdYWDlUUVRzNUxBT2NOWnZOVTE2U2VJYmZsTE5Na25L?=
 =?utf-8?B?c0pjSDdLcEZDS29lQmYvOW1ldksxNy84OWd0aDBCRWJlRGUzNjkvcXJvUEEr?=
 =?utf-8?B?WjJhcUZmb3g5aDlBVGt5TjFtMnd0cHdueDlhMi9WbW51dzhsQ21wWUcrdTMr?=
 =?utf-8?B?elVlVERoQW9nNmtjUmRJaGNlcy9vUmF5bUxsdko1VEhEdW4rYU02OUF1cDZI?=
 =?utf-8?B?YUl1cVNBUDYvZGlialdQMm9DMlBSZEhrTjdqZndTLys0QzNuT3VPYW5qcVhz?=
 =?utf-8?Q?5jPinNjz52CY2qH2edbWdpiGqEzxNQnbCMPMQpJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b690cc3-7f25-4ac8-9f13-08d8ef8ec5aa
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4597.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 13:06:15.5781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wx83H/Zyk78X8yZZ0Ty3UG0JhlXRByVku5ihjWHh+U/pKYfXvzcQESpdJL/FcQ9NpCb7MtL3wPh2sFUhyAzz4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2597
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Joerg,

On 3/18/21 10:31 PM, Joerg Roedel wrote:
> On Fri, Mar 12, 2021 at 03:04:09AM -0600, Suravee Suthikulpanit wrote:
>> @@ -519,6 +521,7 @@ struct protection_domain {
>>   	spinlock_t lock;	/* mostly used to lock the page table*/
>>   	u16 id;			/* the domain id written to the device table */
>>   	int glx;		/* Number of levels for GCR3 table */
>> +	bool giov;		/* guest IO protection domain */
> 
> Could this be turned into a flag?
> 

Good point. I'll convert to use the protection_domain.flags.

Thanks,
Suravee