Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp375911pxf; Thu, 25 Mar 2021 06:17:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZe8gi4XlxYKlUzf3tcIbt5cHZtwWb+PHj/9LWJIdDsPRcQ/ooIaSvQOOqi/N6M9lFAwnW X-Received: by 2002:a5d:5051:: with SMTP id h17mr8893518wrt.80.1616678278723; Thu, 25 Mar 2021 06:17:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616678278; cv=none; d=google.com; s=arc-20160816; b=M9yhDMtuOWSq99dyvJsVkPRTWrYoJlp60kYLBLR0ymIFH9Sit43T0MjOZ/M4AQcsdI zFgN9fFB9LzpWlKVyKRhOD7deJA7wK2bJ8DRVUZmq0ZmlzJF7rc+6Td8W3f96iytgPer 2Njj3uh6hA16/hNE7oPZmj7btA3HMeK2pFuq/o9tlZvnOPj81GwIkfTtA2N1vrQCn8YJ JZySuUiRUvbPy6OOS0SK7eV0xs6IDtHT/cmcbNfbGvm46YjtDgdcRu4QQdGYq7NUlU8S ouBC2baEMH73BBZ12nJPmox9iPsSrMaHrbIQDdD8S2V4ad2u1I+ukZFvTkwDeA9a5CeH 9/rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=pF1vw5byTYFC3u091miEF5l91ShJBPVixkauJ5ZFR7A=; b=wUzvMdKvMobsqxXBecFkQaS5ZFzyEovEkM4TwTMv1qnNlaibmrImQIsW1ckIRrXQtM suo5OntEroQz46BovG8FT7R5HLFjQJq2QYQ+GnleigVTIDXVSPQipoB61iDQxizbyB90 GWgGxXPXsc3Sbc5roMwbgLATVo4biBiqFESPdRtTBj+nbB6bOGRHNwdcTx4Yyi1W9hF1 5fg47MV6imw5qQUoXxLgACc3/X7rEe39EkVHWF/GTMla/fggFF2CuFYjDFR/vV9YMDmC 9ecWQAH03qBZE4SVtsTbFDTwUGqnOegsgeHfhe7daU0oM/O5qj98O50wnXStGI93TWwW kgEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p10si4217864edw.62.2021.03.25.06.17.34; Thu, 25 Mar 2021 06:17:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbhCYNQP (ORCPT + 99 others); Thu, 25 Mar 2021 09:16:15 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14594 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230281AbhCYNQM (ORCPT ); Thu, 25 Mar 2021 09:16:12 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F5ltS4Q9Qz19HZk; Thu, 25 Mar 2021 21:14:08 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Thu, 25 Mar 2021 21:16:02 +0800 From: Miaohe Lin To: CC: , , , , , , , Subject: [PATCH v3 0/5] Cleanup and fixup for mm/migrate.c Date: Thu, 25 Mar 2021 09:15:19 -0400 Message-ID: <20210325131524.48181-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, This series contains cleanups to remove unnecessary VM_BUG_ON_PAGE and rc != MIGRATEPAGE_SUCCESS check. Also use helper function to remove some duplicated codes. What's more, this fixes potential deadlock in NUMA balancing shared exec THP case and so on. More details can be found in the respective changelogs. Thanks! v2->v3: Collect Reviewed-by tag Revert commit c77c5cbafe54 ("mm: migrate: skip shared exec THP for NUMA balancing") per Yang Remove all 3 VM_BUG_ON_PAGE and make putback_movable_page static per Yang v1->v2: Fix removing the wrong assertion per Rafael. Use pr_warn_once() instead per David. Collect Reviewed-by tag. Miaohe Lin (5): mm/migrate.c: make putback_movable_page() static mm/migrate.c: remove unnecessary rc != MIGRATEPAGE_SUCCESS check in 'else' case mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page() mm/migrate.c: use helper migrate_vma_collect_skip() in migrate_vma_collect_hole() Revert "mm: migrate: skip shared exec THP for NUMA balancing" include/linux/migrate.h | 1 - mm/migrate.c | 62 +++++++++++++++-------------------------- 2 files changed, 22 insertions(+), 41 deletions(-) -- 2.19.1