Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp380221pxf; Thu, 25 Mar 2021 06:23:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVOC6CbUsS5fPwJQGSulCmE/j4YelhED0mL7URxunnhTVyPJ9lJcrouIOfFlWGCCIBGYAb X-Received: by 2002:a50:ec96:: with SMTP id e22mr9083540edr.385.1616678583957; Thu, 25 Mar 2021 06:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616678583; cv=none; d=google.com; s=arc-20160816; b=A06Rx4NHJ4t2O7GgPZqqt8aLU5TybsB8IdeZiiCu/6qYcw3c0Y4xDJ5GflFov1e0s9 P6CyRlX5B59ovfaEWonIsimwPymXQDx7fduifGpvBZHgL1NAzYB4st9DJl9fHQiOVpDt Pujgy5543i0W7QKSzeayt/Dj0OX5AOogor4SBMX5t2t2CHMAG+nGSnsHRdcvbmGaSH8E /j+1Z9Np0ff5MC4/Fh1R/sKWh9F1IYnG4WaMCt8baaEH3S4KTxIciQauD43thoQYGkTR sc5ZF3n9sjmHSfIg9LzjdvJPDf0xJichrKETfeMXiR3DVAR/AJjF3Q3OstpS8lFYWnJs NX/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=D+F4BhEdCahaPf+RzBaCtlbaN0hG9/opnlXUF08oC8o=; b=aV6SDWby6lk7K4BCtiqO3RrGnkWWY2O183xEWkYBtf8tFYZqTXBwvohVv7VVGJpvKo w2qkFEXAyltlPenoqyvPp8b+AtO+rR0cx0eeelhvx+hEzmC1svV7GGDZcZG0ZjevtBu8 Dk3V7P4xa6JqNOYVUdkHXnl/iSCLpfe91tg+L+Wx6bD4cpBQxLr2xWZFMhqEzTBhzzs0 jHU3xxvr9PDc25s9l/fxWUb192tcirL5Rgj2KrElm9mzEp9dE89+e70r4Z9FshvGKOZM N/LEipa8mN8Uwwgt4yuvsjnTHvZ/noCR0J9RI3XXnG/CKnXOCHUyN6oIKX/I2YCFrY3R 9hjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si4586968ejx.751.2021.03.25.06.22.39; Thu, 25 Mar 2021 06:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230166AbhCYNVi (ORCPT + 99 others); Thu, 25 Mar 2021 09:21:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:55852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbhCYNVW (ORCPT ); Thu, 25 Mar 2021 09:21:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B723DAC16; Thu, 25 Mar 2021 13:21:21 +0000 (UTC) Date: Thu, 25 Mar 2021 14:21:19 +0100 From: Oscar Salvador To: Wang Wensheng Cc: akpm@linux-foundation.org, pasha.tatashin@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rui.xiang@huawei.com Subject: Re: [PATCH] mm/sparse: Add the missing sparse_buffer_fini() in error branch Message-ID: References: <20210325113155.118574-1-wangwensheng4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325113155.118574-1-wangwensheng4@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 11:31:55AM +0000, Wang Wensheng wrote: > sparse_buffer_init() and sparse_buffer_fini() should appear in pair, or > a WARN issue would be through the next time sparse_buffer_init() runs. > > Add the missing sparse_buffer_fini() in error branch. > > Fixes: 85c77f791390 ("mm/sparse: add new sparse_init_nid() and sparse_init()") > Signed-off-by: Wang Wensheng Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3