Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: P/KZAZhtWsb3siYJQ6aqApP/pSTIw/rOucAgNXdfnKqWtyCIWGUuL1Vzyaz50HARidKCrcy2jD
 hMb4/Y4/Ob6Q==
IronPort-SDR: s84PZ1wzip9QzzxBwviK59uqJwLGtOiq2JCpygHpBsDVhsqnjkLz7in2OYc1bWHfFofW2mP8wa
 Z91DucKLk+Xg==
Date:   Thu, 25 Mar 2021 15:22:22 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration
Message-ID: <YFyOjtTI8XXPKgph@smile.fi.intel.com>
References: <20210325022707.840531-1-wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210325022707.840531-1-wanjiabing@vivo.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> struct task_struct is declared at 9th line. Remove the duplicate.

It seems the duplicate is the other one and you removed wrong one.

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  include/linux/debug_locks.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..0b3187a5290d 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -46,7 +46,6 @@ extern int debug_locks_off(void);
>  # define locking_selftest()	do { } while (0)
>  #endif
>  
> -struct task_struct;
>  
>  #ifdef CONFIG_LOCKDEP
>  extern void debug_show_all_locks(void);
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko