Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp382223pxf; Thu, 25 Mar 2021 06:25:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWyKJ64funrkvqGK/zH0itObqucnnF4D7hWp3ArPHC6jCE/OqBqWkk0wTfVn8TiyQAk8F1 X-Received: by 2002:a17:906:f9d8:: with SMTP id lj24mr9492884ejb.200.1616678750058; Thu, 25 Mar 2021 06:25:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616678750; cv=none; d=google.com; s=arc-20160816; b=FlTbIA1EzQpCHa9wx2FvF69z90yyAlNeBVUA6gHjjpn0ZmkaTknFAB4txpBcO9BFyp W/8zpnJw8KM2zVtzlDj308hrE2CVIM2R3qXiN5WmjWdsVhjs9RwZa3b1zMLmUXh7NCmD b2SH5BPhWR8w3jp7hdWWDBzO15xLOmdkKEGvjQVVWlzLF9GsOF0C1BTyQ865k6G8ymXS hs81oYNV7wFg+2DrUggtZURg95bpqzdnPh1X1hTeZOD3TPfTqJ6F20tifLmGq7w9rNkX ovqw7lo5fjFfw/u7gixkJ0xtWELW2y/b4W938Sc22yJ2bud3cba0CT0fPGcMqnB++Cst wmWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=y6b0+E8fBFPBanCoR73I6ImdtlRCwpKTQ4zUWgzjEq8=; b=Bkv0ZPZ31+A22FGB59qDsNYdQmO7hc3LdGzl4yRiuAwjqs+G/8TIcYbCcm1fgmG+V5 z6CE8eOpOi2xeymIrm23h6x8A5tWfXBPWrkQFzAYKaD6cTcF7CNGlnpsHmP2Fn4NGZEz RK7ftOBV6528vGo3Abary372N1FrXkwjsISO9pDqXfi2VXQaBrNtfU1Z6O3wn9mL32A4 g+ouH0AaesriIgtEo3dD+zTu3FLN7ul3lcU16GeJ4yikuXAidTpOgV/840yTCboPA0BL EjxlxMFZvgNZbcC5h2L+3ErMf9a13J/QopGadBAQbcV6ayL5k0lHmGDJ0mxe8NTC7gA5 OXqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga16si4330507ejc.102.2021.03.25.06.25.25; Thu, 25 Mar 2021 06:25:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbhCYNYS (ORCPT + 99 others); Thu, 25 Mar 2021 09:24:18 -0400 Received: from mga04.intel.com ([192.55.52.120]:7598 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbhCYNXr (ORCPT ); Thu, 25 Mar 2021 09:23:47 -0400 IronPort-SDR: o0ZTxGrFrj72cbYX36iDdY7EUOiQLoNcVQdU6o2sufIAenHjrtAdCuwak3/01eaoxdOH/F/zrE oxOFzOSUd9Fw== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="188628354" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="188628354" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 06:23:47 -0700 IronPort-SDR: j2N33Qd84WMcvnjdw27sNTAmh6DExk6dS+RDKkgYTwUzZhsG6p6MlvV+YRPOqzWUwOI+0oiAU3 oRmrbEpLLV6w== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="375068246" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 06:23:44 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lPPxb-00G3Ks-0i; Thu, 25 Mar 2021 15:23:39 +0200 Date: Thu, 25 Mar 2021 15:23:39 +0200 From: Andy Shevchenko To: Wan Jiabing Cc: Thomas Gleixner , Sergey Senozhatsky , Petr Mladek , Peter Zijlstra , linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration Message-ID: References: <20210325022707.840531-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 03:22:22PM +0200, Andy Shevchenko wrote: > On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote: > > struct task_struct is declared at 9th line. Remove the duplicate. > > It seems the duplicate is the other one and you removed wrong one. Okay, they are on the same level of ifdeffery, technically there is no difference. Practically the other one closer to its user. -- With Best Regards, Andy Shevchenko