Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp382637pxf; Thu, 25 Mar 2021 06:26:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSHm0rX5a7taTLjrudqaPmRSWWtZZ0w8DyHPu8khC7t3QMMX0L8317zSvU0iXZrt0Pc0ID X-Received: by 2002:a17:906:314f:: with SMTP id e15mr9397792eje.30.1616678779133; Thu, 25 Mar 2021 06:26:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616678779; cv=none; d=google.com; s=arc-20160816; b=Qrgx9xFEiiA0aBy268YGcZ7k3E0OkEYusNUNjKDwFUuulnaiWBTywbsb+rOGdY3MKD rHynVF6TMOc2f14snP13N1UXc9jk4fWFjEDa3iPwUJ5ObLDOy645jgVJietr4fSKipNW UMIkWijakSHPE+8fyR5Eg+lnB98FTBDrDM/Q6s+n+J1cslMFaprivhSCSgCztKQDZfhu W4PJqkpPtaTVvXG1KY2qtHLmrecSLREaAEdAt81jCrbYpiPop2A0f64gBv3PHEWGUPOb FndV8rJwncDsAtMZa8q0otbrmXifCL2gCRceRv2eJD1E+NAhHmt3EyreMag+E976DEL8 6n0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=FoPot4yn/913q2goHqTcmxadnQAVEQfJX7+M8LxXsgE=; b=ievHpdk0sHIyQhJGj4+GkxbFQ5ETOl4YLoMN6h9bPGk6eB5seJS2BqRB5FYTa0/y9p RcXhzqa09de3A642oGL3LODfHcGosrz0nxrvQ2ufge24viYkKx8zQTTvL4tb7BWLzFGh JPoAiAKTFtS5FYYtQHSJ9Mn0oeem0VIWMVqYhVxFoF9Ew+7Cs5iq1hfRhRVnKDMfi1tz hSHVzXwAqS2OcmEG3c+yeM7mmVUmrKBS7urOUNea/eZJXTwnhMWKfDaxFjNvh/WQAZQg 7/BdaDlJ+vX/BIUebkU57Mb/La9u7zCMokg0FzgAOkDXNpmIZVXV2RIdLPS99vZKq6VE 4xcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rBvpd6eA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si4339505edv.329.2021.03.25.06.25.55; Thu, 25 Mar 2021 06:26:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rBvpd6eA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbhCYNXO (ORCPT + 99 others); Thu, 25 Mar 2021 09:23:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230229AbhCYNWv (ORCPT ); Thu, 25 Mar 2021 09:22:51 -0400 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3CD4C06174A; Thu, 25 Mar 2021 06:22:50 -0700 (PDT) Received: by mail-qv1-xf33.google.com with SMTP id o19so1147057qvu.0; Thu, 25 Mar 2021 06:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FoPot4yn/913q2goHqTcmxadnQAVEQfJX7+M8LxXsgE=; b=rBvpd6eAuDPCtv4GTnHqF5cEnKcd/vYdb7zaF/LQKNiEGr98XHARNeSQ+kqA4w/BrJ vE8hAmHrarxvYnSGG2nrpeJbNjzsIiH5JJBd3ayc0XgQZ8Wm6emdqFCEUIGWGK/VD1qG 6kGxKnBfuLwUazgMHHl42Dd+0HR4RkmPMVOehCmOlpyhaypT4QgGADQHXi8KsFq3tsfm EMFXQxWtmhCgqPP7WAHfrvnCQ69aQ1sFT9aVHLqsLEYuNyNwKonloXJmitUzF6PaLRVm RVRnsUY3j74Z1uLw3Xn1gofGAl3IdgKmJUSJQ4st9Hvhw2Ue/r7bPF6xhRM1CY1yfzF5 eBIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FoPot4yn/913q2goHqTcmxadnQAVEQfJX7+M8LxXsgE=; b=Va3iC0JEBP60CMW8WBzOnpt3kIGkCn7jdlx+gbXYayErxCmM/EQRjl1gxyaloLk3fx 4pI20ikMlenEPK+nnCQSiPdYNUr3Y/xHXO2rXW4pd8YwZhYPLqMfevCyIf2GSfAbS3Pf n/526uGcbEi2SZEkCWn09TVIxgbO58aGEPEcR0lAg4ojBkNT6QrpSTR8F17n3LLe9QGP nMucNUVLpbcHlkRccOZQ/XSROK0/SW1wJfp/0jO/Jc0OlFED7lsSTjEWaQqzKJEfK1m2 DrrprB1gJZe+2VuKPYv6MifeW+B8GWuvzmPtA7cwwokaqcJNi5SP+yNBgjVcKbHsongx RLsg== X-Gm-Message-State: AOAM532btL+6FmaW82LTmEG1y+uj0nlhfF6N34br4oEaDHMm2dFeYfXj 6jsUQzXlrgr4LSIOzuUkJlhHx/BUlPA8Ysyj+PO+RuU= X-Received: by 2002:ad4:4904:: with SMTP id bh4mr8207440qvb.53.1616678569993; Thu, 25 Mar 2021 06:22:49 -0700 (PDT) MIME-Version: 1.0 References: <20210323023726.28343-1-lihaiwei.kernel@gmail.com> In-Reply-To: <20210323023726.28343-1-lihaiwei.kernel@gmail.com> From: Haiwei Li Date: Thu, 25 Mar 2021 21:22:11 +0800 Message-ID: Subject: Re: [PATCH] KVM: VMX: Check the corresponding bits according to the intel sdm To: LKML , kvm list Cc: Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Haiwei Li Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 10:37 AM wrote: > > From: Haiwei Li > > According to IA-32 SDM Vol.3D "A.1 BASIC VMX INFORMATION", two inspections > are missing. > * Bit 31 is always 0. Earlier versions of this manual specified that the > VMCS revision identifier was a 32-bit field in bits 31:0 of this MSR. For > all processors produced prior to this change, bit 31 of this MSR was read > as 0. > * The values of bits 47:45 and bits 63:57 are reserved and are read as 0. > > Signed-off-by: Haiwei Li > --- > arch/x86/kvm/vmx/vmx.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index 32cf828..0d6d13c 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -2577,6 +2577,20 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf, > > rdmsr(MSR_IA32_VMX_BASIC, vmx_msr_low, vmx_msr_high); > > + /* > + * IA-32 SDM Vol 3D: Bit 31 is always 0. > + * For all earlier processors, bit 31 of this MSR was read as 0. > + */ > + if (vmx_msr_low & (1u<<31)) > + return -EIO; Drop this code as Jim said. > + > + /* > + * IA-32 SDM Vol 3D: bits 47:45 and bits 63:57 are reserved and are read > + * as 0. > + */ > + if (vmx_msr_high & 0xfe00e000) > + return -EIO; Is this ok? Can we pick up the part? :) -- Haiwei Li