Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <39af167527d6478f86431c2ce29f68177700e82d.camel@linux.ibm.com>
Subject: Re: [PATCH] ima: Fix the error code for restoring the PCR value
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Roberto Sassu <roberto.sassu@huawei.com>,
        lihuafei <lihuafei1@huawei.com>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     "dmitry.kasatkin@gmail.com" <dmitry.kasatkin@gmail.com>,
        "jmorris@namei.org" <jmorris@namei.org>,
        "serge@hallyn.com" <serge@hallyn.com>,
        yangjihong <yangjihong1@huawei.com>,
        Zhangjinhao <zhangjinhao2@huawei.com>
Date:   Thu, 25 Mar 2021 11:09:27 -0400
In-Reply-To: <0764ed04a7e84546a8b31fc13b264c47@huawei.com>
References: <20210303032824.124112-1-lihuafei1@huawei.com>
         <9df8d712-0e58-f95d-8f95-5feae2150b42@huawei.com>
         <0764ed04a7e84546a8b31fc13b264c47@huawei.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-03-24 at 09:00 +0000, Roberto Sassu wrote:
> > From: lihuafei
> > Sent: Tuesday, March 23, 2021 2:41 PM
> > ping. :-)
> > 
> > On 2021/3/3 11:28, Li Huafei wrote:
> > > In ima_restore_measurement_list(), hdr[HDR_PCR].data is pointing to a
> > > buffer of type u8, which contains the dumped 32-bit pcr value.
> > > Currently, only the least significant byte is used to restore the pcr
> > > value. We should convert hdr[HDR_PCR].data to a pointer of type u32
> > > before fetching the value to restore the correct pcr value.
> > >
> > > Fixes: 47fdee60b47f ("ima: use ima_parse_buf() to parse measurements
> > headers")
> > > Signed-off-by: Li Huafei <lihuafei1@huawei.com>
> 
> Hi Li Huafei
> 
> yes, correct. Thanks for the patch.
> 
> Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>

The patch set is now queued in next-integrity-testing.

thanks,

Mimi