Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wUY04yVc9r5Dt2yVUdv06++WwL3Q0S1Fn5UdPmVjTX/uhAOzx4cx8Z26rxVT2ij4Yp8praryLA
 UbEG+29Ytolw==
IronPort-SDR: 6cDUMbaEnJZLqHRvdoT0d0GkSb4BITKpu6dJzjYP8JaaGSm6+Gov4Gszx9MP0CTYesGS9+29nL
 Tz2QVy6bbxvQ==
Date:   Thu, 25 Mar 2021 17:43:03 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Daniel Gomez <daniel@qtec.com>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Add base addr info
Message-ID: <YFyvh3sqyVcg8Iqj@smile.fi.intel.com>
References: <20210325151248.1066643-1-daniel@qtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210325151248.1066643-1-daniel@qtec.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote:
> Add i2c hw base address in the adapter name and when the device is
> probed.

Why?
We have /proc/iomem for that.

Sorry, I don't see value of this change.
Some comments  below just to let you know about style:ish issues.

...

>  	snprintf(adap->name, sizeof(adap->name),
> -		 "Synopsys DesignWare I2C adapter");
> +		 "Synopsys DesignWare I2C adapter at 0x%llx", dev->base_addr);

It actually should be resource_size_t and corresponding specifier, i.e. %pa to
print it. Moreover, we have %pR (and %pr) specifiers for struct resource.

...

> +	dev_info(&pdev->dev, "%s\n", adap->name);

Unneeded noise.

-- 
With Best Regards,
Andy Shevchenko