Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp624610pxf; Thu, 25 Mar 2021 10:18:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9H2LpVWA1UC5alAjbFbqAe8NHCqC5wo0YZxSYU9oprq3jZfRmcbeg/zevzvAkIg8YHgJn X-Received: by 2002:aa7:ca04:: with SMTP id y4mr10214780eds.339.1616692705246; Thu, 25 Mar 2021 10:18:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616692705; cv=none; d=google.com; s=arc-20160816; b=JxO60hGGu539W0c/WgoOYCfmjEkrcCvriOcWTNPvA90W8vjzEojlzbsboT+K5PHoe7 keK4FxmOAzjfHIJiBU4R0fUQpQ0A8cHImAOeN8Nu+WRUWVFF0tENhRliPeKWcyrmfTEO 10GXciGBxA7RZhVpo6XdmyPrgUZ6CA5DuYvBsg+GtPlrTjZC/HNo5bxA7GOmmcHtlUoP 3vtxi+6dBQZJhh/ajSn5BMaT6SGhlrUv2SMgK+lDd/TxBJwt6wt6Cyc/lBxIupUZEPQQ kOg7vWnJUmO148PTbvhynpfI74eWUpRxV5pxVpi48EXeuiWfz7VOSiPohBrZNQBSIceR P8Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=b/E9ZQmoRHBY0j5fgj4TMPe8fddtpVSdYdLoClD9tZg=; b=Ft7xWtmkVhiFWJqOvUeBS3kIZ+ArgJP6kO1yBa9sMoxRZFAd/IOhQex3fJ4d4cDq5V 5FnR03Wpld/fX+HBC9/8JPVv6cyxgaoK0EdVxvH367iLuDj58PjP8lnfdTAreyLGe+9n uBUIEMfYPuG24kXjiBvm9WOTJQCCQTeiGHQc8MvMKXTZx/4nTObkwxvLDL8CFCAirme0 2rPofGdjKB0ZSiS05BQXyxWFPZpSCxwnt+Kkug/1zZh67mRNkeXQ1Ou8h+R3HnVvDedN rFlzCvBY9te3OElkr4VQ+QMZJEIz/CS4nSOsdt4OQLj5mNpldugphNFSnuZIOk2oZdDE kTZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E8VU9MDH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si4655793ejs.39.2021.03.25.10.18.02; Thu, 25 Mar 2021 10:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E8VU9MDH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229533AbhCYRQj (ORCPT + 99 others); Thu, 25 Mar 2021 13:16:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:40770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbhCYRQU (ORCPT ); Thu, 25 Mar 2021 13:16:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0483561A16; Thu, 25 Mar 2021 17:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616692580; bh=phmny67lf++X1rkQVwR6baI2+MCDEs3wLD7iAm3xsOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E8VU9MDHPFOdaovt8n/9YdPSCpUyUpJaxNyRawPd3nCxPu/Vk7czI8/ZJWaoeeuTf 2R7t9YGqqT/43VsL64M8tIUa4sP8SqicY5T75O78nf6c9waYFoto0mjNPEw3OJZS40 eFElJ8FxMP5Cc2QPIYS1oEnsKLetLwI5kqj58e/Dcpq010+0kokWUrmdQxxi27C1l4 0yboQp8QEF6PNrPe4ufEMHy19PVfjXOFF2pLq0Q6egatY2jaDG+COxaggbchnJh0mx zCuXAfWT4A5r5anmO/0tHnwfW7ulOWdETLsGuZmLoWMKzLg8Yn/UfHrjcj2SMRApos XxOBd/1Q+3mJQ== Date: Thu, 25 Mar 2021 17:16:14 +0000 From: Will Deacon To: Yong Wu Cc: Joerg Roedel , Matthias Brugger , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Krzysztof Kozlowski , youlin.pei@mediatek.com, Nicolas Boichat , anan.sun@mediatek.com, chao.hao@mediatek.com Subject: Re: [PATCH 1/2] iommu/mediatek-v1: Alloc building as module Message-ID: <20210325171614.GA15433@willie-the-truck> References: <20210323055801.16885-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323055801.16885-1-yong.wu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 01:58:00PM +0800, Yong Wu wrote: > This patch only adds support for building the IOMMU-v1 driver as module. > Correspondingly switch the config to tristate. > > Signed-off-by: Yong Wu > --- > rebase on v5.12-rc2. > --- > drivers/iommu/Kconfig | 2 +- > drivers/iommu/mtk_iommu_v1.c | 9 ++++----- > 2 files changed, 5 insertions(+), 6 deletions(-) Both of these patches look fine to me, but you probably need to check the setting of MODULE_OWNER after: https://lore.kernel.org/r/f4de29d8330981301c1935e667b507254a2691ae.1616157612.git.robin.murphy@arm.com Will