Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210319143231.25500-1-olaf@aepfle.de> <20210325121606.6a2e4e00.olaf@aepfle.de>
 <CAK7LNARPs97+eQKMop9cYCs=D4Kwsf_5pq-614OUxT2iZptueg@mail.gmail.com> <20210325180735.1f0238f1.olaf@aepfle.de>
In-Reply-To: <20210325180735.1f0238f1.olaf@aepfle.de>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 26 Mar 2021 02:32:49 +0900
Message-ID: <CAK7LNATaDL0h6wA16jNBCg=zg8XL2zSSPLyvq6mriLDTjO0LMQ@mail.gmail.com>
Subject: Re: [PATCH v2] kbuild: enforce -Werror=unused-result
To:     Olaf Hering <olaf@aepfle.de>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 26, 2021 at 2:07 AM Olaf Hering <olaf@aepfle.de> wrote:
>
> Am Fri, 26 Mar 2021 01:55:41 +0900
> schrieb Masahiro Yamada <masahiroy@kernel.org>:
>
> > What about  drivers/net/ethernet/lantiq_etop.c  ?
>
> Nothing complained about it. I guess there is a build-bot for alpha, but none for mips.
>
> > I got a lot of complaints in the last trial.
>
> Why did you get complains, instead of me?
>
>
> What is the "must" in "__must_check" worth if it is not enforced...
>
> Olaf


In hindsight, __must_check may not be a perfect name.

Miguel suggested __nodiscard to get along with:
https://en.cppreference.com/w/c/language/attributes/nodiscard

It is not enforcing. Just a compiler warning.


-- 
Best Regards
Masahiro Yamada