Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Marius Bakke <marius@gnu.org>
To:     ricky_wu@realtek.com
Cc:     arnd@arndb.de, bhelgaas@google.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        puranjay12@gmail.com, rui_feng@realsil.com.cn,
        ulf.hansson@linaro.org, vailbhavgupta40@gamail.com
Subject: Sudden poweroffs when idle on ThinkPad x290s since v5.10-rc1
 (bisected to 7c33e3c4c79a)
In-Reply-To: 20200907100731.7722-1-ricky_wu@realtek.com
Date:   Thu, 25 Mar 2021 20:33:16 +0100
Message-ID: <87tuozm3k3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hello,

After updating to the 5.10 kernel, my laptop will spontaneously poweroff
when idle after some time (between 30 minutes and three days).

I have bisected it down to a rtsx driver update in 7c33e3c4c79a:

commit 7c33e3c4c79ac5def79e7c773e38a7113eb14204
Author: Ricky Wu <ricky_wu@realtek.com>
Date:   Mon Sep 7 18:07:31 2020 +0800

    misc: rtsx: Add power saving functions and fix driving parameter
=20=20=20=20
    v4:
    split power down flow and power saving function to two patch
=20=20=20=20
    v5:
    fix up modified change under the --- line
=20=20=20=20
    Add rts522a L1 sub-state support
    Save more power on rts5227 rts5249 rts525a rts5260
    Fix rts5260 driving parameter
=20=20=20=20
    Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
    Link: https://lore.kernel.org/r/20200907100731.7722-1-ricky_wu@realtek.=
com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145 +++++++++++++++++++++++++++++++++=
+++-
 drivers/misc/cardreader/rts5260.c  |  28 +++----
 drivers/misc/cardreader/rtsx_pcr.h |  17 +++++
 4 files changed, 283 insertions(+), 19 deletions(-)

(See also <https://bugzilla.kernel.org/show_bug.cgi?id=3D211809>.)

I'm not sure whether this is a driver or hardware problem and am seeking
feedback on how to further debug the issue.

FWIW the problem does not seem to reproduce on an AMD ThinkPad T14 Gen 1
with the same RTS522A PCIe card reader (on stock Arch 5.10.16 kernel).

Thanks & happy hacking,
Marius

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYFzlfA8cbWFyaXVzQGdu
dS5vcmcACgkQ6HGLpZEUEHf4ngD+LGctGYG2EYdNavgHwhsvYsfyjXRMo6lrr+fO
NCX2074A/3dOuSD880jXBrGi/NymBDhkUGID/X0MwUrzxoYzXwgN
=DJhI
-----END PGP SIGNATURE-----
--=-=-=--