Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp749112pxf; Thu, 25 Mar 2021 13:11:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW+KT/T1TE0BHNvdsnO8ZqMLl520rmE04qFiB67IL/tYcpgx646zX6QWuFi+Uu5mIOhx33 X-Received: by 2002:aa7:dc56:: with SMTP id g22mr11142880edu.219.1616703088712; Thu, 25 Mar 2021 13:11:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616703088; cv=none; d=google.com; s=arc-20160816; b=OmgoL8MEMpE0+WaLG87g1I0v+xvLgpIDfLqRvN3YfnDzBV1/IdzF/O3Q2qP+co9wlL 3solg8j8GL75rPgoxPkCtFDGtHsKJtYfPZMQGDEgGtpzN0Y4T2V7A8ZFPVQb82xyMQh1 oqpbwjCXZ0ZhJJTUbenmOrRaLtYAk1QSVmEwtSKPJo7j4o9scsn9w9K5/Xv1VB/emzfE 2YLJx9GqpvwBTR09eEbsOisKRTug2mnaIbNVVoEZyFFlYPP9WWb+3SxeVzgbXQsIbIIC jZ+akzHG+TTHI10c13du3uMzz52bGpo2AwOS9KtzhqGCcgWECyF5pJMPWbTco11m2d+q apKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=D2vku1A4QvBUs3er+RFyi03Y9hQGsZzmhfOh4GWoyxg=; b=LoNHkKkkuszBxYwyK8PrGuP09zHZUSJ3YMS47SGc6hbpdyKwR5WHRkbjtLufj+92J9 GsGbz6+mEdtZnMtqLVE/sRm2AQos1+H6P/IBDH7TKqNIjooh1WS5MKiZa9kouAhvrxHx Y/rsc8H+HmQOCXPmTkjezhCF09IXyBQsS26hjgatUPMRQuVUpMDJ50Fn7AOi7M4h3p/0 UlQltgHT24r5XmDn4DJQLCTyteFmb+ZAJp8AZoiH8nIQS3UoRtSjl2Tv7zRzHGLyjU1i vZYn5RjbIVKPFf/izSnML3Rkp+4ixWfUJiDrh0bTM05Prrx3aOtc31jy0uSXMfLYHGj3 AZGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=RcFJXNF8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si5085598ejk.245.2021.03.25.13.11.06; Thu, 25 Mar 2021 13:11:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=RcFJXNF8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230313AbhCYUKJ (ORCPT + 99 others); Thu, 25 Mar 2021 16:10:09 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:55352 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbhCYUJ4 (ORCPT ); Thu, 25 Mar 2021 16:09:56 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12PK9e9X093749; Thu, 25 Mar 2021 15:09:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1616702980; bh=D2vku1A4QvBUs3er+RFyi03Y9hQGsZzmhfOh4GWoyxg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=RcFJXNF8iaDsCYT1UNDl3ibmGk5VNUk8KVlZ9Qcv6NrVvMmaNH5kbMcZnQI1sYYOd vkG7+x/LbuKOCTBDlNDrCZChOxPdESbJSocAQy4FEcgIguibpDVp6/y0VUc/AqxfDP ezhynDXb/du9Okgv+ztHYJC9cm0wni7UPFENFyr8= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12PK9eIe001197 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 25 Mar 2021 15:09:40 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 25 Mar 2021 15:09:40 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 25 Mar 2021 15:09:40 -0500 Received: from [10.250.33.213] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12PK9edB130879; Thu, 25 Mar 2021 15:09:40 -0500 Subject: Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs To: Mathieu Poirier CC: Bjorn Andersson , Grzegorz Jaszczyk , Jan Kiszka , Lokesh Vutla , Vignesh Raghavendra , linux-remoteproc , , linux-arm-kernel , Linux Kernel Mailing List References: <20210315205859.19590-1-s-anna@ti.com> <20210323232014.GA1782475@xps15> <2f8bfc4f-e43d-5e38-fc6d-7045c69af364@ti.com> From: Suman Anna Message-ID: Date: Thu, 25 Mar 2021 15:09:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/25/21 12:36 PM, Mathieu Poirier wrote: > On Wed, 24 Mar 2021 at 11:09, Suman Anna wrote: >> >> On 3/23/21 6:20 PM, Mathieu Poirier wrote: >>> On Mon, Mar 15, 2021 at 03:58:59PM -0500, Suman Anna wrote: >>>> The K3 PRUs are 32-bit processors and in general have some limitations >>>> in using the standard ARMv8 memcpy function for loading firmware segments, >>>> so the driver already uses a custom memcpy implementation. This added >>>> logic however is limited to only IRAMs at the moment, but the loading >>>> into Data RAMs is not completely ok either and does generate a kernel >>>> crash for unaligned accesses. >>>> >>>> Fix these crashes by removing the existing IRAM logic limitation and >>>> extending the custom memcpy usage to Data RAMs as well for all K3 SoCs. >>>> >>>> Fixes: 1d39f4d19921 ("remoteproc: pru: Add support for various PRU cores on K3 AM65x SoCs") >>>> Signed-off-by: Suman Anna >>> >>> Probably a good idea to CC stable as well... >>> >>> Reviewed-by: Mathieu Poirier >> >> Thanks Mathieu. This patch is already staged on Bjorn's rproc-fixes branch >> though and part of linux-next since next-20210319. I have posted an additional >> 3-patch series for some more PRU fixes. Do you want me to post a v2 for those >> with stable Cc'd? > > I didn't notice Bjorn had already picked it up. Since the object is > now public there is no need to send a V2 for this one. I haven't > looked at your other 3-patch series but if you think it is stable > material then yes, please send a new revision that CC stable. Alright, will do. regards Suman > > Mathieu > >> >> regards >> Suman >> >>> >>>> --- >>>> drivers/remoteproc/pru_rproc.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c >>>> index 2667919d76b3..16979c1cd2f4 100644 >>>> --- a/drivers/remoteproc/pru_rproc.c >>>> +++ b/drivers/remoteproc/pru_rproc.c >>>> @@ -585,7 +585,7 @@ pru_rproc_load_elf_segments(struct rproc *rproc, const struct firmware *fw) >>>> break; >>>> } >>>> >>>> - if (pru->data->is_k3 && is_iram) { >>>> + if (pru->data->is_k3) { >>>> ret = pru_rproc_memcpy(ptr, elf_data + phdr->p_offset, >>>> filesz); >>>> if (ret) { >>>> -- >>>> 2.30.1 >>>> >>