Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp843568pxf; Thu, 25 Mar 2021 15:34:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTfTNhJqy9x3u1lDtRNJ/jk1fi+2KOQaGStQrRi3p1NCCP+SU7+Brz22esO11X/8VbfQpD X-Received: by 2002:a17:907:7651:: with SMTP id kj17mr12082889ejc.127.1616711685038; Thu, 25 Mar 2021 15:34:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616711685; cv=none; d=google.com; s=arc-20160816; b=k4hHWu0CBurgL+YELhYiF2CHcLAXUqVo9G22z0pEd80C3hQyKLF5TjLBdoJY7/uuSz 78oA5xILgbde76UZW8TFoC5EWn+zCKE69p2sD6p4IHaTSytajn9hINi9iHzmhxCcTd7R SmnkIgGIaffQD1rOUt0OuCjfXyHRZcI2iLQ3h262nbBrq9qv0rBoscnzsoDgiqXs2KSN Upp4TajTadYkrpEvMo5YctLdCjcK6LCb7sx4irHpMc3g1s992k4/VIVWcMMBqRsRFyQD Ls1YGri+V+oG3w9i5WNvDz9KAw/VcKjVYPal91uSPF1C3eBHfXIG20yBTJiXsplcNExw y5LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EmLcgF1u9OHQdNQJvc1RdIqmppq+TxMi8g7LBfwF3pg=; b=q49vzB3VSbGy4oAwOLHqwEuH1Oeaj1zlk8ivzhT70bGQvLe5RFkp7TyZmn0i1uf8rT jjTPED0X+TY+1w7hF5SvPxuyke5IVSmXbDv0vrP8hE/Ro5K8tC7xDig4BC/JAw1yd3HT A6OcMo2qgOlVv95ja/iElqBHstj69adKrRCTGikEMYv7O5e5s0kqmWQBC5M0K7R/ED6O DVPTuI4e5CHgE8Dt0jaxiiqzxgvZq9+lczeXjttYUGB4cbznNKRNhw1CQyJ7F7Kh/JSs iMx5QtbSrtRAi6qs8pKFbw6xQUpbvY/7YZwItMqsA7U0HCe0vqWJdCoKykzu/wLL2Gwr S9xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="RWpg+/Qe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si4930845edc.137.2021.03.25.15.34.22; Thu, 25 Mar 2021 15:34:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="RWpg+/Qe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230468AbhCYWbz (ORCPT + 99 others); Thu, 25 Mar 2021 18:31:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbhCYWbt (ORCPT ); Thu, 25 Mar 2021 18:31:49 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9175CC06174A; Thu, 25 Mar 2021 15:31:49 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id v3so3271011pgq.2; Thu, 25 Mar 2021 15:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EmLcgF1u9OHQdNQJvc1RdIqmppq+TxMi8g7LBfwF3pg=; b=RWpg+/QeRT9vqXNET5uBaFAyAO+jQ0pdYIM1O46KSP7ptGhLDWrxy/nYmBcI5Vgbho 0QjtbA4pMNvJQGfPARYzelplKtcZyIfrUOHSoLed7ILyR8LHjGxPodt1fL+Erez4NIYC /y7PQorfEZxx5+7w/dwXEKBgks7rLMk4bgZUDyKt4lp5oYR/bF0Bm70C4It69OxwGi0h Sxn3t7+2nSgpGyVf9DVRIwj4mb9vwh3Tw2DD+e7OQ7Xa68kVD2hAj92KKRj+xcx8WBaK gbhUrd9YqlsGh/GsKnmnWsnCusW+M7c2rYMVz931/wJSYwG3X/vp+9cXQMtmeuOWBZ6q hTJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EmLcgF1u9OHQdNQJvc1RdIqmppq+TxMi8g7LBfwF3pg=; b=lAtvByB7uU2Y1nokGPtct/D/VziOz2VJtzIs0G8ZttGsOjKYIBptXNsasIn9wSfUjN EiKibL3QSBB0PrCSTcGxV29gxlPuH7ipgAVC9oQr6AYhGv6p0RHGarO6cqRJifocEOIq Wt2QgwPuiuTBPOGUF7vBJN4msK7CLp56cIVm7TLfyv9RrfYNJe20tm+PLasgp9HPreS9 zpqpmhAWvVIcActqu/M9AnnN1k0zv8SagRK1ajtwpSmrO9FYodeNpq/8oqtmGMvKeRjK 5zxFIInUnqt0K5d6KV6GMGgID2KbtTZwEk5IxZ/cAfWb5TEveOrkcXFRkKkP86KI/alj zIsA== X-Gm-Message-State: AOAM532ZIQW5Vtu0JW36fdtO2w69lRAhkRVdwmTf3tk2MrgLWygYNWJF SaFzFZJg2fnFCg2lNn5NH+c= X-Received: by 2002:a17:902:d64a:b029:e6:30a6:64e3 with SMTP id y10-20020a170902d64ab02900e630a664e3mr12368679plh.28.1616711508991; Thu, 25 Mar 2021 15:31:48 -0700 (PDT) Received: from google.com ([2620:15c:202:201:3991:e59d:d2d4:59dd]) by smtp.gmail.com with ESMTPSA id w189sm6546399pfw.86.2021.03.25.15.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 15:31:47 -0700 (PDT) Date: Thu, 25 Mar 2021 15:31:44 -0700 From: Dmitry Torokhov To: Barry Song Cc: tglx@linutronix.de, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org, gregkh@linuxfoundation.org, linuxarm@openeuler.org, jonathan.cameron@huawei.com Subject: Re: [PATCH v5 2/2] Input: move to use request_irq by IRQF_NO_AUTOEN flag Message-ID: References: <20210302224916.13980-1-song.bao.hua@hisilicon.com> <20210302224916.13980-3-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210302224916.13980-3-song.bao.hua@hisilicon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 03, 2021 at 11:49:16AM +1300, Barry Song wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable because of requesting. > > On the other hand, request_irq() after setting IRQ_NOAUTOEN as > below > irq_set_status_flags(irq, IRQ_NOAUTOEN); > request_irq(dev, irq...); > can also be replaced by request_irq() with IRQF_NO_AUTOEN flag. > > Signed-off-by: Barry Song Applied, thank you. -- Dmitry