Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] prctl: PR_SET_MM - unify copying of user's auvx
To:     Cyrill Gorcunov <gorcunov@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Alexey Dobriyan <adobriyan@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Andrey Vagin <avagin@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
References: <YFeuWsnb6qKEU8+h@grain> <YFpmdGXmGQ6IetoX@grain>
From:   Dmitry Safonov <0x7f454c46@gmail.com>
Message-ID: <14931afb-903b-e7c6-5276-416dab5f08ed@gmail.com>
Date:   Fri, 26 Mar 2021 00:24:47 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YFpmdGXmGQ6IetoX@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Cyrill,

On 3/23/21 10:06 PM, Cyrill Gorcunov wrote:
[..]
> --- linux-tip.git.orig/kernel/sys.c
> +++ linux-tip.git/kernel/sys.c
> @@ -1961,6 +1961,30 @@ out:
>  	return error;
>  }
>  
> +static int copy_auxv_from_user(unsigned long *auxv, size_t auxv_size,
> +			       const void __user *addr, size_t len)
> +{
> +	BUG_ON(auxv_size != sizeof(current->mm->saved_auxv));

Nit:
size_t auxv_size = sizeof(user_auxv);
BUILD_BUG_ON(sizeof(user_auxv) != sizeof(current->mm->saved_auxv));

(to make it local variable instead of a parameter and get rid of a new
BUG_ON())

> +
> +	if (!addr || len > auxv_size)
> +		return -EINVAL;
> +
> +	memset(auxv, 0, auxv_size);
> +	if (len && copy_from_user(auxv, addr, len))
> +		return -EFAULT;
> +
> +	/*
> +	 * Specification requires the vector to be
> +	 * ended up with AT_NULL entry so user space
> +	 * will notice where to stop enumerating.
> +	 */
> +	if (len == auxv_size) {
> +		auxv[AT_VECTOR_SIZE - 2] = AT_NULL;
> +		auxv[AT_VECTOR_SIZE - 1] = AT_NULL;

I don't follow why it became conditional.
Perhaps, you meant that memset(0) above will zerofy it anyway, but in
case (len == auxv_size - 1) it won't work. Or I'm missing something
obvious :-)

Thanks,
           Dima