Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp986510pxf; Thu, 25 Mar 2021 20:44:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3KiL9zKbYe+zDnBRoXn4oNo+uq6/d8BVlG0FCTAK4SmWGwSBSwJs7KTkrbPhNN32tNqxc X-Received: by 2002:a17:906:cb18:: with SMTP id lk24mr12617310ejb.70.1616730261102; Thu, 25 Mar 2021 20:44:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616730261; cv=none; d=google.com; s=arc-20160816; b=bGde9+ngxfiYJlFiGTXg6LHjfujPMupgcxus2u/Qea8Qe7XU2j19t1H8xNcb6i66T1 nbc5kBChuwIne1HSIIBF02GzJLajlBfnyzO/kKxglyp6XB1gGkKktlob6U1xAjTi8s35 4OoyrdFNgrMUtS/zH4QqkWmb0la7JX60fkQQk5PajbAiEsf4lgBH62oqB6/IfGMF4/z/ tWimS1vhcXmowfrRqbW3Kqj7PjRSV+0WEau2R9ktQhjbuo79Q/joPU8Htxhn5CU8prOt saP5yUDPGEXLGC5KoMAxfguevE81QV18WS4bSoKekxNBEMbb9oxjZ06TdgHg5JZEOrg6 8U6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=S3aM59LzwZv2lhTP9C0ITO0CQL7/3mTFFH7WMQjCEiU=; b=qPZ9mBP5z+RC3jVgJoqAMpwIU7za20K1CYKW8A7jr0mKQLxePSc/fXMo6adJ8RcZ36 MyqwaLN/Y5iaiJRqJCC4RS6jb0pqhfBjkqb7nvcOY4Choce7oqa2vz42X6zvVHMYJ9gY /ZwgdVrqBGQiCNlTzToPLSbOkeLEYhlUTNq2R68+lc+Zsa1RiyRFqBrZJkMM0EagadL6 eYsvRi/esUkLss3VSrYHk4mFl2ZVxdenb63kF3FFKLm0AcbImAxduEktnz8ia9/+kKDP k2a7XxqYcsOI3iJwlLAdi0hXB+5OsM1n0CF9TAoaM81NgGj/1oz1dZwds8D7APznyHFi kRXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="N4Z+WQ/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r14si5512741ejb.283.2021.03.25.20.43.55; Thu, 25 Mar 2021 20:44:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="N4Z+WQ/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbhCZDmz (ORCPT + 99 others); Thu, 25 Mar 2021 23:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbhCZDm0 (ORCPT ); Thu, 25 Mar 2021 23:42:26 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D992C06174A; Thu, 25 Mar 2021 20:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S3aM59LzwZv2lhTP9C0ITO0CQL7/3mTFFH7WMQjCEiU=; b=N4Z+WQ/0D63wmvnhgzwQTM+nmf yHCwotlJqph2PP5rp2afCDzn0M0r/qd4LphT504V1vClIfCS42aw/ChtGSLtQR25PPTZpEVR7mBfV xetgewEuFA0Z5yR0TWnadlD+i3Ge967HX8RMosXugO2B7130o39Lf5qyClEiLkQ6U1iSUDuQMdCXC mLLRQqrqGboWT3pw409QtubI7+bLlxGCvzhZ/anulvSkLdnMQ6lN2jyqnfRAZQUkSCX8K5yLEaiaA 40nYIlasmrInug/FdILDGXfruXcYMGK657AdZcSd+VbxHYjywoAwWfEHTEe2I96ogXoE3/TFkC2O+ FyF0F/fg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lPdMO-00EEBG-Rh; Fri, 26 Mar 2021 03:42:10 +0000 Date: Fri, 26 Mar 2021 03:42:08 +0000 From: Matthew Wilcox To: Qinglang Miao Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] mm/page_alloc: remove duplicated include from page_alloc.c Message-ID: <20210326034208.GC1719932@casper.infradead.org> References: <20210326025542.3565329-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326025542.3565329-1-miaoqinglang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2021 at 10:55:42AM +0800, Qinglang Miao wrote: > Remove duplicated include. > > Reported-by: Hulk Robot > Signed-off-by: Qinglang Miao can't you make hulk robot do something useful, like untangle the mass of header includes? For example, in -next, net/ipv4/tcp.c has a dependency on pagemap.h. Why?