Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Daniel Axtens <dja@axtens.net>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, mpe@ellerman.id.au
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, paulus@samba.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/iommu/debug: Remove redundant NULL check
In-Reply-To: <1616406217-94635-1-git-send-email-jiapeng.chong@linux.alibaba.com>
References: <1616406217-94635-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Date:   Fri, 26 Mar 2021 16:53:30 +1100
Message-ID: <87r1k2795x.fsf@linkitivity.dja.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi Jiapeng Chong, <jiapeng.chong@linux.alibaba.com> writes:

> Fix the following coccicheck warnings:
>
> ./fs/io_uring.c:5989:4-9: WARNING: NULL check before some freeing
> functions is not needed.

This looks correct to me, and matches the description of debugfs_remove
in Documentation/filesystems/debugfs.rst.

If you have a number of similar fixes it might be helpful to do them in
a single bigger patch, but I'm not sure if coccicheck reports much else
as I don't have coccinelle installed at the moment.

Reviewed-by: Daniel Axtens <dja@axtens.net>

Kind regards,
Daniel