Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hermes Zhang <Hermes.Zhang@axis.com>
To:     "pavel@ucw.cz" <pavel@ucw.cz>, "dmurphy@ti.com" <dmurphy@ti.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hermes Zhang <Hermes.Zhang@axis.com>,
        "lkml@axis.com" <lkml@axis.com>, kernel <kernel@axis.com>
Subject: Re: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED
 driver
Thread-Topic: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED
 driver
Thread-Index: AQHXIgDn9WkVNzIcREGb9FBG0Jikcw==
Date:   Fri, 26 Mar 2021 06:07:26 +0000
Message-ID: <05c93a739a404e3cb181802619258674@XBOX01.axis.com>
References: <20210326052801.17666-1-chenhui.zhang@axis.com>
 <20210326052801.17666-3-chenhui.zhang@axis.com>
 <20210326055559.izdyzb5gwgwthv4i@falbala.internal.home.lespocky.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

On 3/26/21 1:56 PM, Alexander Dahl wrote:=0A=
>> +=0A=
>> +module_platform_driver(multi_gpio_led_driver);=0A=
>> +=0A=
>> +MODULE_AUTHOR("Hermes Zhang <chenhui.zhang@axis.com>");=0A=
>> +MODULE_DESCRIPTION("Multiple GPIOs LED driver");=0A=
>> +MODULE_LICENSE("GPL v2");=0A=
>> +MODULE_ALIAS("platform:leds-multi-gpio");=0A=
> I did not review thouroughly, but in my mail the indentation looks=0A=
> wrong. Did checkpatch complain?=0A=
=0A=
Sorry, I forgot to check the style before commit, but seems one problem=0A=
about extra space:=0A=
=0A=
$ chkernel=0A=
ERROR: space prohibited before that ',' (ctx:WxW)=0A=
#164: FILE: drivers/leds/simple/leds-multi-gpio.c:76:=0A=
+            + sizeof(u8) * nr_states , GFP_KERNEL);=0A=
                                                   ^=0A=
=0A=
I will fix it in next commit.=0A=
=0A=
=0A=
Best Regards,=0A=
=0A=
Hermes=0A=
=0A=
=0A=