Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210325212202.142945-1-alaaemadhossney.ae@gmail.com> <YF2JF+UMdt/icEMj@kroah.com>
In-Reply-To: <YF2JF+UMdt/icEMj@kroah.com>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Fri, 26 Mar 2021 08:14:30 +0100
Message-ID: <CACT4Y+Y8f6-c6zYCN=d0557xEryAzBfS9n2m=vBcdjHSi5gYcw@mail.gmail.com>
Subject: Re: [PATCH] media: sq905.c: fix uninitialized variable
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Alaa Emad <alaaemadhossney.ae@gmail.com>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        syzkaller <syzkaller@googlegroups.com>,
        syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 26, 2021 at 8:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Mar 25, 2021 at 11:22:02PM +0200, Alaa Emad wrote:
> > Reported-by: syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com
> > Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
> > ---
>
> I know I do not take patches with no changelog text, but other
> maintainers might be more leniant :(

I wonder if it's the right fix or not.
Initializing variables will, of course, silence the warning, but it's
not necessarily the right fix. I suspect there is something wrong in
how ret/act_len are user/checked.