Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Mar 2021 10:25:17 +0100
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     bhelgaas@google.com,
        "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: Disable D3cold support on Intel XMM7360
Message-ID: <YF2ofVoGlEb07NYm@rocinante>
References: <20210324111316.250576-1-kai.heng.feng@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210324111316.250576-1-kai.heng.feng@canonical.com>
Precedence: bulk

Hi,

Thank you for sending the patch over!

[...]
> +static void pci_fixup_no_d3cold(struct pci_dev *pdev)
> +{
> +	pci_info(pdev, "disable D3cold\n");

Not sure how useful this message would generally be?  Unless this is
useful to someone who is doing some troubleshooting, etc.

> +	pci_d3cold_disable(pdev);
> +}
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x7360, pci_fixup_no_d3cold);
[...]

A small suggestion: a brief comment, perhaps even linking to the
Bugzilla, might be a nice touch here, so that people would know why
D3cold is being disabled for XMM7360, etc.

Krzysztof