Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1186659pxf; Fri, 26 Mar 2021 03:00:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyys9X4I4ii0auNojrcXdxG+9uwQM/JpkAtpiuT4mSsBfRfMXFkbemq/owr16nQ4zqwThJ7 X-Received: by 2002:a05:6402:3096:: with SMTP id de22mr13972074edb.141.1616752816177; Fri, 26 Mar 2021 03:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616752816; cv=none; d=google.com; s=arc-20160816; b=VlqX/KI6VhwcKFmots83Ec0qsCO6xlegsOKNHaBXbMcg7PsaVvjImLKNEJkp7uIlRq JfTci6R0b2gRNOB8ifpQNHdrFH+ME90tHnlDBudymvOG6aSK453oFu+BFDMCVoBfyFZk mnTCLmgc/SYaDGWh8Tclh47mXgCsf5enUdwLIbRarNWEeStp01TIiPNkcDm10AUYgp4J FJdh6wYf32Q22272X8cLyXbbOqagrGzlTxngx8cA11RgPPjcNYIQ3xHFkGams/ISgKtr GEnWVgRcZY5t4NHpquh2oVBmoEi7a/XXiJbdokJZpz/CyeZ57ktWaC9wMIMkk/SyoDy5 X3IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+8ftwX2VrGSkfTVVNvT7pPS6qh2Bu/od5mahErd+MM4=; b=vd23rpLVTbyfsRTzQv0o89BtTN5w20rfnZv9CbJYzaLGK+CQfD1Dr+rn4Jx/Cq0dl4 xIxVDd+V8HlW864aMXoO8W3cHYHT3qLLgGcEEXapjb7lja2CnWlXr3nPS+iULOoLw6oZ lGe02M0Pfrg3GWbjIoYujxZ5U1SYtq0sd9aDStevbSmNVbv/ODTMaotJY0w6V//cyIwG IE4vHOf9poqa3hxp0MlUspYnzk+A4WrhQwUW+di7pHC7WQiYMqH2LkCASuc0zNON+MOW CAVir4XZ10dybwF+PsvC0q6xYeF2ij2gkegJI/7QoUBOUzZzGU6MFL9/bVZaqWUQsNl2 1YTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kzTUDDX8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay27si6302919edb.171.2021.03.26.02.59.53; Fri, 26 Mar 2021 03:00:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kzTUDDX8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230041AbhCZJ6z (ORCPT + 99 others); Fri, 26 Mar 2021 05:58:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbhCZJ6r (ORCPT ); Fri, 26 Mar 2021 05:58:47 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDC91C0613B4 for ; Fri, 26 Mar 2021 02:58:46 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id l4so7465923ejc.10 for ; Fri, 26 Mar 2021 02:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+8ftwX2VrGSkfTVVNvT7pPS6qh2Bu/od5mahErd+MM4=; b=kzTUDDX8a25F/i/c+v4G5fzlR44A/rmT2kECv9pBhJHo+lau9PUuofsQ+YlK4ppSnD O7kf1K88iSJYxmLPQACECAOQWQRGy5DKOZpShKgscx+Q1JM1Tn26K6mGR83xM9azjk7x +M8Ua7lcupbG0pFsxDfaby/8GVBJJmVkJHd3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+8ftwX2VrGSkfTVVNvT7pPS6qh2Bu/od5mahErd+MM4=; b=tD9+X770P4d3JbL19saHcbPS5/SsIHt2+3bRUsGAu1nqrctsE6SQISbhv0cTmN3czB 5iPi7yA9elV9s85qZ26liApEo03JqS9UFyAy+b0rC4rWHDa9P8RbbYUpyEgiL3qn/Agl Kofoc7SdnAh+RS2eXbxtJXzCS9BvPNCVl12S+L9KaQGaWsaKPg66lujhQz8Mx42uVcVg BhllzP7u5xfgHIXgOfD1tGSeOxCQWtKop6IxefpNLs+W1BCOQKVRfCytfeVKcAUvzQhC GmjdLhgDQk1a1f6B/rxwdWJuTeRBHHq5uCTtewKdL/2MibfrgGRTC0kDWXcdvw/MUiVh gm7A== X-Gm-Message-State: AOAM531SQq8c/KgByukBAIWMDQGwwEh9qAmOKfDJzHkoY/Q8HP8Ibquj N+X9ipU5XIRgaY5DfFSLKFrzAA== X-Received: by 2002:a17:907:7699:: with SMTP id jv25mr13834135ejc.363.1616752725723; Fri, 26 Mar 2021 02:58:45 -0700 (PDT) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id h13sm4036658edz.71.2021.03.26.02.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 02:58:45 -0700 (PDT) From: Ricardo Ribalda To: Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, tfiga@chromium.org Cc: Ricardo Ribalda , Mike Isely Subject: [PATCH v9 02/22] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL Date: Fri, 26 Mar 2021 10:58:20 +0100 Message-Id: <20210326095840.364424-3-ribalda@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210326095840.364424-1-ribalda@chromium.org> References: <20210326095840.364424-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is written. Cc: Mike Isely Signed-off-by: Ricardo Ribalda Reviewed-by: Hans Verkuil --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c index 9657c1883311..c04ab7258d64 100644 --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c @@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv, unsigned int idx; int ret; - /* Default value cannot be changed */ - if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL) - return -EINVAL; - ret = 0; for (idx = 0; idx < ctls->count; idx++) { ctrl = ctls->controls + idx; -- 2.31.0.291.g576ba9dcdaf-goog