Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1285431pxf; Fri, 26 Mar 2021 05:09:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkzUdlwsbCVso0Kd159iI4Sr/WqreIgafrEkWji+Jrr8hQXQdxN1JqZWMZ239IjWgKTUP4 X-Received: by 2002:a17:906:c143:: with SMTP id dp3mr14585258ejc.499.1616760588703; Fri, 26 Mar 2021 05:09:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616760588; cv=none; d=google.com; s=arc-20160816; b=rEls874Miq7XWro9KMzPPK4Mo0tmzMqq31lop3QHNZvVBNVn88QJw0Vhlj8HidkDUM q0hCZ2RWmOD7heBSJK+gJ7n/W1i7DrTxjVb94gaJkr/MLUG7dCRscSPNZm2oZnnNF6sr g322ifnDpgBFS7HM9SNY7qYL1zBxmVpSd7MP2OMXZPmZciPy1eAkXu5VYzi0RiKEHew+ mV70xCgEO3vedzNf+/cyqejBWkRYeH/18vuH8PElLNgqz/09uWWG1GOzxW99iI30IsCb QyrOvUtFLLFVeFr+ir8EjVwx1kyZRbfcCY9xdiprTVI4aAjZt8hw7YkNQ/zZflgmR7no Jwog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wsPJ5OsoQaCiybtyefFDZvxhqYlDd9cwiCGrBDHbxv4=; b=qdcry0Zmvqd0oh0R+Q5fl0xinfKsJ9oEbaNdeYOHzt1qBmix1BsiEFQQ92PHnXXosU 37eYlzdGQDmJ6+4Z116drk4KJ1wyYhSEU1bMTQRxMzyduK/Xh7WSLcGj12HF7gAvRn5y FahY10LI80CCNvSZ3w6c3VoN2JvTAoeiCKh16l6qzizNjAUayv5AQzrdmYnCmvCU7tj7 FkzCvGbiMrMmLSeksXI5KXkjacbd9ry9zIYVAz4ki2XbnSWXRKVziHI+QqWca7VTsgj0 yI3HuZU6WgwYcmGu0r6oRaVcOlgGECMh8xgLzSrDE7fz650oh+QO+3FYT7v/X8XSs9Lx EHKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LEfmAR51; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si6484373eds.403.2021.03.26.05.09.26; Fri, 26 Mar 2021 05:09:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LEfmAR51; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbhCZMHS (ORCPT + 99 others); Fri, 26 Mar 2021 08:07:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:46766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhCZMG4 (ORCPT ); Fri, 26 Mar 2021 08:06:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED6F4619C2; Fri, 26 Mar 2021 12:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616760416; bh=7UC8bFowAEClcuVmD8pmoLMke7GDpMaFrDzgTuRPHjs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LEfmAR518L35KZ26PpXjs08EvGsDI1bRuUY5lc85mGzGB64n0qI94MUh23nbCkKjm kmM2e2nuAxPESftH4KWV9HSI6cpHbBmOFff3K7Od3eZaso8gB7m7e45h2B9XeruF2W mzFLnfCKZe/Noc336KbgiPCPYghXGOHolLSFowLVUGIzyGrIRtm+JTP5/R1AEzeorG e/GEe5widZTOgTA4xQcSK5WFWOa8cMn4+5eGwd8Dlt1HDlmnBsqBYVJRnK8lYD5mlY ziPAQ4oTBvDc3ZSJP/NFJmzLMRocAh81PUfoj3UGoJWT+amR511VTlX5f1aDAbhIVw ZcsK35mA67lSg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 8C29F40647; Fri, 26 Mar 2021 09:06:53 -0300 (-03) Date: Fri, 26 Mar 2021 09:06:53 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim , Yang Jihong Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Yao Jin , gustavoars@kernel.org, mliska@suse.cz, linux-kernel , zhangjinhao2@huawei.com Subject: Re: [PATCH v7] perf annotate: Fix sample events lost in stdio mode Message-ID: References: <20210319123527.173883-1-yangjihong1@huawei.com> <33ba152e-b8ef-3057-744a-51cb8c478ff2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Mar 26, 2021 at 12:25:37PM +0900, Namhyung Kim escreveu: > On Fri, Mar 26, 2021 at 11:24 AM Yang Jihong wrote: > > On 2021/3/19 20:35, Yang Jihong wrote: > > > In hist__find_annotations function, since different hist_entry may point to same > > > symbol, we free notes->src to signal already processed this symbol in stdio mode; > > > when annotate, entry will skipped if notes->src is NULL to avoid repeated output. > > > > > > However, there is a problem, for example, run the following command: > > > > > > # perf record -e branch-misses -e branch-instructions -a sleep 1 > > > > > > perf.data file contains different types of sample event. > > > > > > If the same IP sample event exists in branch-misses and branch-instructions, > > > this event uses the same symbol. When annotate branch-misses events, notes->src > > > corresponding to this event is set to null, as a result, when annotate > > > branch-instructions events, this event is skipped and no annotate is output. > > > > > > Solution of this patch is to remove zfree in hists__find_annotations and > > > change sort order to "dso,symbol" to avoid duplicate output when different > > > processes correspond to the same symbol. > > > Signed-off-by: Yang Jihong > Acked-by: Namhyung Kim Without looking at the patch, just at its description of the problem, I tried to annotate two events in a group, to get the annotate group view output with both events, and it seems I'm getting samples accounted for both events: [root@five ~]# perf record -e '{branch-misses,branch-instructions}' -a sleep 1 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 2.296 MB perf.data (2507 samples) ] [root@five ~]# [root@five ~]# perf report | grep -v '^#' | head -5 17.49% 19.19% ThreadPoolForeg chromium-browser [.] v8::internal::ConcurrentMarking::Run 12.17% 17.04% ThreadPoolForeg chromium-browser [.] v8::internal::Sweeper::RawSweep 11.14% 11.63% ThreadPoolForeg chromium-browser [.] v8::internal::MarkingVisitorBase::ProcessStrongHeapObject 7.65% 7.84% ThreadPoolForeg chromium-browser [.] v8::internal::ConcurrentMarkingVisitor::ShouldVisit 5.66% 6.72% ThreadPoolForeg chromium-browser [.] v8::internal::ConcurrentMarkingVisitor::VisitPointersInSnapshot [root@five ~]# perf annotate --stdio2 v8::internal::ConcurrentMarking::Run Samples: 444 of events 'anon group { branch-misses, branch-instructions }', 4000 Hz, Event count (approx.): 596221, [percent: local period] v8::internal::ConcurrentMarking::Run() /usr/lib64/chromium-browser/chromium-browser Percent Disassembly of section .text: 0000000003290b30 : v8::internal::ConcurrentMarking::Run(v8::JobDelegate*, unsigned int, bool): push %rbp mov %rsp,%rbp push %r15 push %r14 mov %rdi,%r14 push %r13 mov %edx,%r13d push %r12 mov %ecx,%r12d push %rbx sub $0x1298,%rsp mov %rsi,-0x1228(%rbp) mov %fs:0x28,%rax mov %rax,-0x38(%rbp) movzwl 0x2(%rbx),%eax test %ax,%ax ↓ jne 4a9 mov -0x10e8(%rbp),%rdx cmpw $0x0,0x2(%rdx) 0.41 0.39 ↓ je 4b90 movq %rbx,%xmm0 movq %rdx,%xmm2 mov %rdx,%rbx punpcklqdq %xmm2,%xmm0 movups %xmm0,-0x10e8(%rbp) movzwl 0x2(%rdx),%eax 4a9: sub $0x1,%eax mov %ax,0x2(%rbx) 0.36 0.91 movzwl %ax,%eax 0.60 0.00 mov 0x10(%rbx,%rax,8),%rax 3.44 2.46 mov %rax,-0x11e0(%rbp) 0.00 0.34 4bf: mov 0x8(%r13),%rax 0.00 0.36 add $0x1,%r15d 0.00 0.34 mov 0x110(%rax),%rax mov 0x128(%rax),%rcx 0.88 0.36 mov 0x8(%r13),%rax mov 0x110(%rax),%rdx mov 0x130(%rdx),%rdx 0.00 0.48 mov 0x140(%rax),%rax mov 0x110(%rax),%rsi 0.61 0.47 mov -0x11e0(%rbp),%rax 2.01 2.32 sub $0x1,%rax cmp %rcx,%rax 0.00 0.35 setae %cl 1.31 0.33 cmp %rdx,%rax setb %dl 0.00 0.24 test %dl,%cl 0.00 0.12 ↓ jne 4b70 cmp %rsi,%rax ↓ je 4b70 mov (%rax),%eax 29.10 29.90 add -0x1220(%rbp),%rax cmpb $0x0,-0x1218(%rbp) mov %rax,-0x1210(%rbp) 0.00 0.65 ↓ jne 4fa0 mov -0x11e0(%rbp),%r9 lea 0x6(%rax),%rbx 0.38 0.00 545: movzbl (%rbx),%eax 4.90 5.34 cmp $0x4c,%al ↓ ja 5026 0.58 0.00 550: lea v8::internal::FLAGDEFAULT_abort_on_contradictory_flags+0x457,%rdi movslq (%rdi,%rax,4),%rax 4.97 3.19 add %rdi,%rax If I ask for number of samples: [root@five ~]# perf config annotate.show_nr_samples=true [root@five ~]# perf annotate --stdio2 v8::internal::ConcurrentMarking::Run Samples: 444 of events 'anon group { branch-misses, branch-instructions }', 4000 Hz, Event count (approx.): 596221, [percent: local period] v8::internal::ConcurrentMarking::Run() /usr/lib64/chromium-browser/chromium-browser Samples Disassembly of section .text: 0000000003290b30 : v8::internal::ConcurrentMarking::Run(v8::JobDelegate*, unsigned int, bool): push %rbp mov %rsp,%rbp push %r15 push %r14 mov %rdi,%r14 push %r13 mov %edx,%r13d push %r12 mov %ecx,%r12d push %rbx sub $0x1298,%rsp mov %rsi,-0x1228(%rbp) mov %fs:0x28,%rax mov %rax,-0x38(%rbp) movzwl 0x2(%rbx),%eax test %ax,%ax ↓ jne 4a9 mov -0x10e8(%rbp),%rdx cmpw $0x0,0x2(%rdx) 1 1 ↓ je 4b90 movq %rbx,%xmm0 movq %rdx,%xmm2 mov %rdx,%rbx punpcklqdq %xmm2,%xmm0 movups %xmm0,-0x10e8(%rbp) movzwl 0x2(%rdx),%eax 4a9: sub $0x1,%eax mov %ax,0x2(%rbx) 1 2 movzwl %ax,%eax 1 0 mov 0x10(%rbx,%rax,8),%rax 8 5 mov %rax,-0x11e0(%rbp) 0 1 4bf: mov 0x8(%r13),%rax 0 1 add $0x1,%r15d 0 1 mov 0x110(%rax),%rax mov 0x128(%rax),%rcx 3 1 mov 0x8(%r13),%rax mov 0x110(%rax),%rdx mov 0x130(%rdx),%rdx 0 1 mov 0x140(%rax),%rax mov 0x110(%rax),%rsi 2 1 mov -0x11e0(%rbp),%rax 6 6 sub $0x1,%rax cmp %rcx,%rax 0 1 setae %cl 2 1 cmp %rdx,%rax setb %dl 0 1 test %dl,%cl 0 1 ↓ jne 4b70 cmp %rsi,%rax ↓ je 4b70 mov (%rax),%eax 58 73 add -0x1220(%rbp),%rax cmpb $0x0,-0x1218(%rbp) mov %rax,-0x1210(%rbp) 0 1 ↓ jne 4fa0 mov -0x11e0(%rbp),%r9 lea 0x6(%rax),%rbx 1 0 545: movzbl (%rbx),%eax 10 13 cmp $0x4c,%al ↓ ja 5026 1 0 550: lea v8::internal::FLAGDEFAULT_abort_on_contradictory_flags+0x457,%rdi movslq (%rdi,%rax,4),%rax 9 8 add %rdi,%rax So it seems to be working, what am I missing? Is this strictly non group related? - Arnaldo