Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1291056pxf;
        Fri, 26 Mar 2021 05:16:02 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxW47hF8PzupIHeD552TwoNYKzL3ELtDE6jjA5g+lQ2TA2Zp4kFYjIcj3aM/UM0BYQLOAsZ
X-Received: by 2002:a50:ed90:: with SMTP id h16mr14631966edr.101.1616760962391;
        Fri, 26 Mar 2021 05:16:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1616760962; cv=none;
        d=google.com; s=arc-20160816;
        b=bwDQ7AFYOkhYzWP07aPUUKkAlVTJQnF6qHL8r4dfFsyXsdfn5N1hAO14HKK9taogHC
         g19D/iED5w4yJq9n514Cyx9LGbQb2f0gldFS+WGaRHqTsUhLI4Cf6GTdXnphZlAnbm+O
         jC5BRVglF4Z4M/aPzU74So5LbRQ9YjVcBUw/n/uo4T7Fn2T1k3zGqjoNqtGOwAUW1DZZ
         q9GB2fPeyyT2EuR3gGw8YzbENlV7c7m6zjPs5MzE3nlI+QTabh1n0yjEmYCEzHgEe1QC
         gin1H9zNKbEeM4WIGgDnHimBQBFoxbKK8XY8Xb6hKlpEji3+efuJWhdUQBzuNrJv3l78
         hIug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=JjLoQbXKA6ItwzflAaUW+mg4quBrqnrgp2Ll8uCM2j8=;
        b=XyqLhj5W1R2w0oMKJBL5MUSdgqRhC8lcNz/IdBLicJXo5kMm9/pQ+Rd0L3TE7Vgb9i
         tS5WXHEt1lWKdVUQra17uIvePxKwXgDWiQsJfMa+gt0CkUKZKRwPINKse2bqG8n4b+/P
         qFd1waHxyR5+T+oE9KFPluoXT3FwLYjLIS5RBzHs/jMc8niB0Pd161B1qi5+ssbt8nFC
         BpiOUJrbggdrZDZ/4mNlJgEvMN/XCe4/NGBjZe6eHEaBk0fhE2uHSPCwS5xLyBmN0y6b
         O11cMteb/sjQptBlPM/sJo8D14tO4fb8KGHCVMMwyZ3Pq2OsqljsLs0wKllcDTv4qrYy
         WKRA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l26si6411830ejc.536.2021.03.26.05.15.38;
        Fri, 26 Mar 2021 05:16:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229871AbhCZMOZ (ORCPT <rfc822;magnus.damm@gmail.com>
        + 99 others); Fri, 26 Mar 2021 08:14:25 -0400
Received: from verein.lst.de ([213.95.11.211]:45475 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229744AbhCZMOB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Mar 2021 08:14:01 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 529B367373; Fri, 26 Mar 2021 13:13:59 +0100 (CET)
Date:   Fri, 26 Mar 2021 13:13:59 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     yanfei.xu@windriver.com
Cc:     hch@lst.de, axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: export disk_part_iter_* helpers
Message-ID: <20210326121359.GA14989@lst.de>
References: <20210326121059.597172-1-yanfei.xu@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210326121059.597172-1-yanfei.xu@windriver.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 26, 2021 at 08:10:59PM +0800, yanfei.xu@windriver.com wrote:
> From: Yanfei Xu <yanfei.xu@windriver.com>
> 
> disk_part_iter_* helpers might be used by other external modules, like
> lttng-modules. But it was unexport in 'commit bc359d03c7ec ("block: add
> a disk_uevent helper")'. Here export them again.

Err, no.  We never export things for out of tree modules.  And any kind
of driver code has absolutely no business looking at the partition tables
to start with, modular or not.