Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 1/2] memory: tegra20: Correct comment to MC_STAT
 registers writes
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
Cc:     linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
References: <20210323210446.24867-1-digetx@gmail.com>
 <799f54f6-6023-338f-4e8f-cc0dfbac30d8@gmail.com>
 <63a3225e-7cae-8592-653e-04a76b7cf9c1@canonical.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <93d5c6db-5ac3-fcc0-41c7-44c146bdccfe@gmail.com>
Date:   Fri, 26 Mar 2021 16:22:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <63a3225e-7cae-8592-653e-04a76b7cf9c1@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

26.03.2021 10:38, Krzysztof Kozlowski пишет:
> On 25/03/2021 18:20, Dmitry Osipenko wrote:
>> 24.03.2021 00:04, Dmitry Osipenko пишет:
>>> The code was changed multiple times and the comment to MC_STAT
>>> registers writes became slightly outdated. The MC_STAT programming
>>> now isn't hardcoded to the "bandwidth" mode, let's clarify this in
>>> the comment.
>>>
>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>> ---
>>>  drivers/memory/tegra/tegra20.c | 5 ++---
>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/memory/tegra/tegra20.c b/drivers/memory/tegra/tegra20.c
>>> index 14caf5b9324c..4659c0cea30d 100644
>>> --- a/drivers/memory/tegra/tegra20.c
>>> +++ b/drivers/memory/tegra/tegra20.c
>>> @@ -451,9 +451,8 @@ static void tegra20_mc_stat_gather(struct tegra20_mc_stat *stat)
>>>  	control_1 = tegra20_mc_stat_gather_control(&stat->gather1);
>>>  
>>>  	/*
>>> -	 * Reset statistic gathers state, select bandwidth mode for the
>>> -	 * statistics collection mode and set clocks counter saturation
>>> -	 * limit to maximum.
>>> +	 * Reset statistic gathers state, select statistics collection mode
>>> +	 * and set clocks counter saturation limit to maximum.
>>>  	 */
>>>  	mc_writel(mc, 0x00000000, MC_STAT_CONTROL);
>>>  	mc_writel(mc,  control_0, MC_STAT_EMC_CONTROL_0);
>>>
>>
>> Krzysztof, please feel free to squash these 2 minor follow up patches
>> into the original patch which added the the debug support, if you prefer
>> this way more. I happened to notice these small itches only after you
>> already picked up the previous patch.
> 
> No problem, in general I prefer to have incremental improvements.

Thank you.