Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] platform/surface: clean up a variable in
 surface_dtx_read()
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <YF3TgCcpcCYl3a//@mwanda>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <e614021b-62aa-c879-c324-fc1dc1eec73e@gmail.com>
Date:   Fri, 26 Mar 2021 15:06:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YF3TgCcpcCYl3a//@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/26/21 1:28 PM, Dan Carpenter wrote:
> The "&client->ddev->lock" and "&ddev->lock" are the same thing.  Let's
> use "&ddev->lock" consistently.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Good catch, thanks!

Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

> ---
>   drivers/platform/surface/surface_dtx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
> index 1fedacf74050..63ce587e79e3 100644
> --- a/drivers/platform/surface/surface_dtx.c
> +++ b/drivers/platform/surface/surface_dtx.c
> @@ -487,7 +487,7 @@ static ssize_t surface_dtx_read(struct file *file, char __user *buf, size_t coun
>   			if (status < 0)
>   				return status;
>   
> -			if (down_read_killable(&client->ddev->lock))
> +			if (down_read_killable(&ddev->lock))
>   				return -ERESTARTSYS;
>   
>   			/* Need to check that we're not shut down again. */
>