Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1398030pxf; Fri, 26 Mar 2021 07:10:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyW/WNNDxhzge0KCVWnIkvbXbkYtmfMfKsQ4KFKn/G0RGB5D2AM/vPXhf1D78HGpgbmbczI X-Received: by 2002:a17:907:62a7:: with SMTP id nd39mr15607491ejc.510.1616767842727; Fri, 26 Mar 2021 07:10:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616767842; cv=none; d=google.com; s=arc-20160816; b=xxFDDVzAFY6mXqNI59+nNtSoBsCXnIDTfyNlkiNDALnUId92xcY2OtmQTlMwSj/AhS 76ZWYCmppdQarBY+rxAJbNK7gry3JgXgqIw5+ARPUVvp2XZXFOZ+suoexrXPqXT/VDSF tXd4tT2CzJqA0rfaDGYQiGRFB9PWygNdB9akctj8Eh2nJAeK48nzTyV/Ylrppn3T5zQd TUH3pTsAtUpyorPUX0YGDKNq3VDJpgayOqtXfnhsXYQQd52m38ngazEojJ0XmDXdxAkC m3MSeGUHnYXZFVeyjtaToMVzdl7k1/tReyq7F4a2vdaJWL6Zlfk+WHwxxD9oYT5IbaFh tzwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from; bh=kH9uN0C3QTB6A4IziabnvNvPzUrCOfhe/sa3xhtStvk=; b=Pb23erI7RRTeVxGgUcr3iWvZHi/sWwDBJFLUvUn8/dYBD1ATAfvd0OfLCxE4WmwIpf 4ijEpfK73oJqmviIyh2McDpSY+tv/0WV10X0zZpr8d77fh15o4lXXMfITQq8F5LpJ4ZM cTiPwhSg3PxV9rNoZLEWheUph9QsRoSCsnTSvfft4zZ+Wzd6ka0HqZRO9PwHho2XdQLL Z/rz9rmnyrTnmc+YnDB94DDYE+STfPy4vXX/0AU4RQkH4zo9VxwxSBpSAKc8QKTUA3Xt qsqOlIaOU5mAUtC+mkPFJb4fGucu1vJDvrkuTC5b5o+nfOCYts8iDH44C4iaHIEsueYz 8ZPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si2306777ejg.204.2021.03.26.07.10.19; Fri, 26 Mar 2021 07:10:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbhCZOJB (ORCPT + 99 others); Fri, 26 Mar 2021 10:09:01 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:36066 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhCZOIe (ORCPT ); Fri, 26 Mar 2021 10:08:34 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F6P2d6PvWz1ryY1; Fri, 26 Mar 2021 15:08:25 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F6P2d4qBqz1qqwS; Fri, 26 Mar 2021 15:08:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id onoyYkV_BZHU; Fri, 26 Mar 2021 15:08:24 +0100 (CET) X-Auth-Info: OEvAU2bUcvvTBFMfvWGLhYIW4WQnHRDFk1cZLlSNZz300DmBDLQfVXreztynDrlR Received: from igel.home (ppp-46-244-160-134.dynamic.mnet-online.de [46.244.160.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Mar 2021 15:08:24 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 998042C35E3; Fri, 26 Mar 2021 15:08:22 +0100 (CET) From: Andreas Schwab To: Christophe Leroy Cc: will@kernel.org, danielwa@cisco.com, robh@kernel.org, daniel@gimpelevich.san-francisco.ca.us, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, microblaze , linux-mips@vger.kernel.org, nios2 , openrisc@lists.librecores.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE References: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> X-Yow: I'd like some JUNK FOOD... and then I want to be ALONE -- Date: Fri, 26 Mar 2021 15:08:22 +0100 In-Reply-To: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Fri, 26 Mar 2021 13:44:58 +0000 (UTC)") Message-ID: <87zgyqdn3d.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mär 26 2021, Christophe Leroy wrote: > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index f8f15332caa2..e7c91ee478d1 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -228,10 +229,8 @@ static void __init parse_dtb(void) > } > > pr_err("No DTB passed to the kernel\n"); > -#ifdef CONFIG_CMDLINE_FORCE > - strlcpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."