Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1426550pxf; Fri, 26 Mar 2021 07:38:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXwVk0wYbzEsIRtaw1axDeVM6E77m6RNrSGrW1CcLwDxPql5U44YC6p+Yq7aYynhGBwz6e X-Received: by 2002:a17:906:a44a:: with SMTP id cb10mr15376112ejb.424.1616769510160; Fri, 26 Mar 2021 07:38:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616769510; cv=none; d=google.com; s=arc-20160816; b=wfk4xdmyh+KJAUPI80NWqHJWcroJ7egmMG+kcOwPZE0H1FvFKIi5qAub/CtjD8PF+0 +l1UXTcWhMNC53rHiXUSkxLX45r4CdxrYslRxOXOju5Pt+ojrnnXSTh4I1CbVwXhw3Z7 XqlZMaWCY/FJHpltSA2+fWJWJ4gZR89PugqPgO0M89zAJTlwOk9pFt8NubEjv35XdKqL n/iYvIW2aQduiS3FfVcdvss0pXlkBzDWvk4v860VRQIZC3+CcfWyzkoFBysGkxc0gUR7 +byF9NsGXiEOD6eUbX7TfNNcPqexKT0goecqvdbiA3HjJQI0bLnJ5FsAR1gS2GDAh8Au 6TOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=WdlBwvqrmCwa0Tfsfsq55niftxmdCk2znctzaWyZ6D8=; b=umigOTk7UmRzkE7SQ13BLKfcLMlctZBt0yfWnrAC1O9bHruNU+AHfsJMlNNfJQ7Lyr 3NaLgS0L6bGtGdLBQeLzLwKaz33Du6mOthE01AIusWEaJqRDChOCHlWzLvrI7hVem3ob RyNkO4+rQiiL0C8hkhjbk+tVzBIKXTIiWcfBJyPxSlw/cIjFRcXIDyHJgxd6qKdjdQtI joxVLh+uS/npxfjJLUPeAd0VesgfYps2noo6Vp6nhGYdqQiqZreXmrZ6WkUHGTFyvPWg TAX+9rYwoJ4dabRERMw5g8SNn3jzOF1hcKbV/1V/vX8xSUSKZWxtcucKUcZb7X5vsYOb aBsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bc10si7264866edb.235.2021.03.26.07.38.07; Fri, 26 Mar 2021 07:38:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231388AbhCZOg4 (ORCPT + 99 others); Fri, 26 Mar 2021 10:36:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:49794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbhCZOge (ORCPT ); Fri, 26 Mar 2021 10:36:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B5A4619F2; Fri, 26 Mar 2021 14:36:32 +0000 (UTC) Date: Fri, 26 Mar 2021 14:36:30 +0000 From: Catalin Marinas To: Masahiro Yamada Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Will Deacon Subject: Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig Message-ID: <20210326143630.GD5126@arm.com> References: <20210324071128.1723273-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324071128.1723273-1-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote: > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is > evaluated every time even for Make targets that do not need the linker, > such as "make ARCH=arm64 install". > > Recently, the Kbuild tree queued up a patch to avoid needless > compiler/linker flag evaluation. I beleive it is a good improvement > itself, but causing a false-positive warning for arm64 installation > in linux-next. (Thanks to Nathan for the report) > > Kconfig can test the linker capability just once, and store it in the > .config file. The build and installation steps that follow do not need > to test the liniker over again. > > Reported-by: Nathan Chancellor > Signed-off-by: Masahiro Yamada > --- > > I was not sure what the preferred CONFIG option name is. > Please suggest a one if you have a better idea. > > > arch/arm64/Kconfig | 3 +++ > arch/arm64/Makefile | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) Would you like this patch to go in via the arm64 tree or you will queue it via the kbuild tree? Thanks. -- Catalin