Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-type: text/plain; charset=utf-8
MIME-version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ...,
 ...)
From:   Norman Maurer <norman_maurer@apple.com>
In-reply-to: <8eadc07055ac1c99bbc55ea10c7b98acc36dde55.camel@redhat.com>
Date:   Fri, 26 Mar 2021 11:22:16 +0100
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, dsahern@kernel.org
Content-transfer-encoding: quoted-printable
Message-id: <CF78DCAD-6F2C-46C4-9FF1-61DF66183C76@apple.com>
References: <20210325195614.800687-1-norman_maurer@apple.com>
 <8eadc07055ac1c99bbc55ea10c7b98acc36dde55.camel@redhat.com>
To:     Paolo Abeni <pabeni@redhat.com>
Precedence: bulk

Hi,

> On 26. Mar 2021, at 10:36, Paolo Abeni <pabeni@redhat.com> wrote:
>=20
> Hello,
>=20
> On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote:
>> From: Norman Maurer <norman_maurer@apple.com>
>>=20
>> Support for UDP_GRO was added in the past but the implementation for
>> getsockopt was missed which did lead to an error when we tried to
>> retrieve the setting for UDP_GRO. This patch adds the missing switch
>> case for UDP_GRO
>>=20
>> Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
>> Signed-off-by: Norman Maurer <norman_maurer@apple.com>
>=20
> The patch LGTM, but please cc the blamed commit author in when you add
> a 'Fixes' tag (me in this case ;)

Noted for the next time=E2=80=A6=20

>=20
> Also please specify a target tree, either 'net' or 'net-next', in the
> patch subj. Being declared as a fix, this should target 'net'.
>=20

Ok noted

> One thing you can do to simplifies the maintainer's life, would be =
post
> a v2 with the correct tag (and ev. obsolete this patch in patchwork).

I am quite new to contribute patches to the kernel so I am not sure how =
I would =E2=80=9Cobsolete=E2=80=9D this patch and make a v2. If you can =
give me some pointers I am happy to do so.


>=20
> Side note: I personally think this is more a new feature (is adds
> getsockopt support for UDP_GRO) than a fix, so I would not have added
> the 'Fixes' tag and I would have targeted net-next, but it's just my
> opinion.

I see=E2=80=A6 For me it seemed more like a bug as I can=E2=80=99t think =
of a reason why only setsockopt should be supported for an option but =
not getsockopt. But it may be just my opinion :)

>=20
> Cheers,
>=20
> Paolo
>=20

Thanks
Norman