Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1484823pxf; Fri, 26 Mar 2021 08:31:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzMrNYTQ16WYv9t5Q3IkDPoiXt0TkT356aTnQoBSlJ6mCEXQQ1uOIc5NrQrnUJIt6RiHMr X-Received: by 2002:a05:6402:5211:: with SMTP id s17mr15930243edd.327.1616772702069; Fri, 26 Mar 2021 08:31:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616772702; cv=none; d=google.com; s=arc-20160816; b=IeIlDzQgUvuzRl8JZvDfuD1dG36Fmcs/mcEYrpIh22eDpcEkRImltgRWmhvVLeUH+H +pRjRv11J0D86WLWAITkQf9s1uWpKgUdBDtDx4H+SEvEGwAw5ZijldSNVcALeR/2QtE3 sOUnm7/9YXV9h7V18vJBofuW+7Knj1H+C6zyq/BS4BxiO6rRisszxukg9Ragcgq0jdhF NmAADY//49HqS0yHcuE1O8Z3gRoMxE51Qw/9vGI81fFHfbB9u9LvA5FkIca1Sq007F+o vFLhh8QZ9U8uHXVnVRpebt4JT/t6xZeBrKVO9a5B77HOOI9Z50uv56LED4HOlf0PaBpx Vm9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=77VWnbkqjOeQ+Q68SYbTBjzvDSMphM8I7bFnWwC9w+g=; b=VSwdOb3SOW9+zv9v0PEWgnjykeeKWfxfoJq8pSPX2GtNujVdcsgHaw1jl/1elDBO3J 8zC3LxmAgIPgGSJ+VX1Q1Uvmwm/i+y79pktwiOpA+javQAcbXO/FglBDYaYIoe19JfuY IexcHJcN5QCDJgCZS+9MFGki+qWtw/wSrTacDHaa8PTBVhr5EJzIYosyUbsXxaHnj4nR Yh6Rf3gQFzucI3VdiQURY3dBkxCCehd8nfrvMWs2W5vAMvAgET4jHfzU5VWbdSflrp1g r05fqtKKp9FbzT5FCDZALqvAphrXWvCdMQaI2i37SwBu6wI62Y5bXW/03GWhCbwEbpJ3 3FvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=OEQnzqpF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a6si6689884ejt.551.2021.03.26.08.31.19; Fri, 26 Mar 2021 08:31:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=OEQnzqpF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230320AbhCZP3y (ORCPT + 99 others); Fri, 26 Mar 2021 11:29:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbhCZP3g (ORCPT ); Fri, 26 Mar 2021 11:29:36 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C84EEC0613B2 for ; Fri, 26 Mar 2021 08:29:33 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id x16so5787909iob.1 for ; Fri, 26 Mar 2021 08:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=77VWnbkqjOeQ+Q68SYbTBjzvDSMphM8I7bFnWwC9w+g=; b=OEQnzqpF0Hexv8ugCa0UYyj6CoA9HrLplF0qh0DVNVcPM1CLKZpgYQwYxjII8kiorP m6SRbo5w7csLtzUz6VxZF/d9uHGHt3V3QvVhoy5CD5koMjHS+sfdjSpLA7ESpJiay9pA miqBAvjtXBnmPuwh6qSgIMC7EFkwaU3sUEynuKy69KGbPunEoFuB6rZN4frOYwXn+Jxm iO1ATd8ilesgG2esVCvB9Ii/kVZs+P3Wru+AYjfseTQKQvCB8B2UD+OGYaX4Fe/UTLmp KU7pO4etJFvZYD8snZT11YY6I2kZOrvMqbGDt6vJIn8PWY8kPeVHZc63Wm+e+GAI5jb/ XOog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=77VWnbkqjOeQ+Q68SYbTBjzvDSMphM8I7bFnWwC9w+g=; b=IqRKhMY0A9DvDa+aGoqU1HkUKH8De1xp87CcIxsCoBapzx5aqVSYm7e9NUv6CeVzD3 MLqdrblSwo6CE6fuIDw9dJzJzyRpuxALJK6GF+UO1L4NFMQE8DdrxOqc4jDAwSDVTyXN 89axdF0HcyONaNMF4t6TjsWrf8U2q/of+NUVhA2DH+QGMlx3q+pT1fVgYxTQDVNdZQGg vlw9zIUTN+bIzv/FpDO6ZCuSI03GNw4BOKIbpqtj5tb/UsELKwfcVw0g1lA+nKpdHEov hA8tmH8f6udtbJSBX7pNVw7Hc10jJb6+RaZ1NcvKMAj5zAr1CYQItnoCZ0Kd2L3/0Jfz sNDQ== X-Gm-Message-State: AOAM5320Wd+nYm2sasTc76dIvegEbMhpaZvaxj+FHJmWPp147QQqf3JR xMBlG7upSJkNA88BdPkLGy3phY+GZC2kKQ== X-Received: by 2002:a05:6602:1207:: with SMTP id y7mr10758082iot.23.1616772572869; Fri, 26 Mar 2021 08:29:32 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id x20sm4537794ilc.88.2021.03.26.08.29.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 08:29:32 -0700 (PDT) Subject: Re: [PATCH 2/8] kernel: unmask SIGSTOP for IO threads To: Stefan Metzmacher , Oleg Nesterov Cc: io-uring@vger.kernel.org, torvalds@linux-foundation.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org References: <20210326003928.978750-1-axboe@kernel.dk> <20210326003928.978750-3-axboe@kernel.dk> <20210326134840.GA1290@redhat.com> <8f2a4b48-77c9-393f-5194-100ed63c05fc@samba.org> From: Jens Axboe Message-ID: <58f67a8b-166e-f19c-ccac-157153e4f17c@kernel.dk> Date: Fri, 26 Mar 2021 09:29:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8f2a4b48-77c9-393f-5194-100ed63c05fc@samba.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/26/21 9:23 AM, Stefan Metzmacher wrote: > Am 26.03.21 um 16:01 schrieb Jens Axboe: >> On 3/26/21 7:48 AM, Oleg Nesterov wrote: >>> Jens, sorry, I got lost :/ >> >> Let's bring you back in :-) >> >>> On 03/25, Jens Axboe wrote: >>>> >>>> With IO threads accepting signals, including SIGSTOP, >>> >>> where can I find this change? Looks like I wasn't cc'ed... >> >> It's this very series. >> >>>> unmask the >>>> SIGSTOP signal from the default blocked mask. >>>> >>>> Signed-off-by: Jens Axboe >>>> --- >>>> kernel/fork.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/kernel/fork.c b/kernel/fork.c >>>> index d3171e8e88e5..d5a40552910f 100644 >>>> --- a/kernel/fork.c >>>> +++ b/kernel/fork.c >>>> @@ -2435,7 +2435,7 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node) >>>> tsk = copy_process(NULL, 0, node, &args); >>>> if (!IS_ERR(tsk)) { >>>> sigfillset(&tsk->blocked); >>>> - sigdelsetmask(&tsk->blocked, sigmask(SIGKILL)); >>>> + sigdelsetmask(&tsk->blocked, sigmask(SIGKILL)|sigmask(SIGSTOP)); >>> >>> siginitsetinv(blocked, sigmask(SIGKILL)|sigmask(SIGSTOP)) but this is minor. >> >> Ah thanks. >> >>> To remind, either way this is racy and can't really help. >>> >>> And if "IO threads accepting signals" then I don't understand why. Sorry, >>> I must have missed something. >> >> I do think the above is a no-op at this point, and we can probably just >> kill it. Let me double check, hopefully we can just remove this blocked >> part. > > Is this really correct to drop in your "kernel: stop masking signals in create_io_thread()" > commit? > > I don't assume signals wanted by userspace should potentially handled in an io_thread... > e.g. things set with fcntl(fd, F_SETSIG,) used together with F_SETLEASE? I guess we do actually need it, if we're not fiddling with wants_signal() for them. To quell Oleg's concerns, we can just move it to post dup_task_struct(), that should eliminate any race concerns there. -- Jens Axboe