Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1506371pxf; Fri, 26 Mar 2021 08:52:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4j/6pZaezA4bL1Gr5/hd+WYGoMdw9mlFSS0uTzqABaOYEz0lOvA1ItY8exSYiQIjzceF0 X-Received: by 2002:a17:906:85b:: with SMTP id f27mr16389792ejd.414.1616773921958; Fri, 26 Mar 2021 08:52:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616773921; cv=none; d=google.com; s=arc-20160816; b=PftoAvzOg2kA+IkUs0tKrYLbhnYmeb4eHV2itWmykDXYgd+4cHiHwvBTQgK5ioC+Mk DLT4/mjFLtfKbiVlG5ENpHdnEMGYw8mic3JrT8cIaiUy1fAGBkb8BDcrK9GyYnqB7V+Z njQbIUD2phImiOaZanInDOzw1wbRhfbwkPsQj0Ml4CdMMZeyikaDdqvjM70L/Bt1fqzy fFRUppCmiXGvdqRMPd+7b18moAPJTGNO/0ocFRl7leA69rItD7PNUJGMz2A3Vg4jWfPR dfHxSP89yXkeaVzPDlPBo7uwmQxLKcTRUpAnzNHIwfB3YglBf1aSRJkWQBJ76iZOLtcy fNgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=GQ+WOeOlEf0oSbrtjjrF/EJp/9rYmvxxCs8KN5vemZ8=; b=qc5UOti9CRoaezFVC1XVg+h9EMGecz1r7dT/FmR651MoAgxvBx/Sha3g0z+OTMWOfi h6Thz7jjEaYwzTd7DNV2wp3RSF5hN1ze855BnoLRrwvLe5BML0FLfQTxWli0sYpAxuB5 IW3pyACRryaERSNV3MuHAEIOxgrZVhdx8PiQXKmVmYmMs1lTvKs6heD+rwzWrm1lHURq PZwHTpcSP8Inv5Dar51kV+9mLFh99pY5onAFSla6aU0hvHHwYdc+5FOZV0Z/NcZQ6Otm 4RWxih/olxm4CB00PR4CRCkhY+L/dPmX0TrPhBO/NPQtJcKizoQPXQrNAiqaS0ek3nIc 0DoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si7017771ejb.59.2021.03.26.08.51.39; Fri, 26 Mar 2021 08:52:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230319AbhCZPue (ORCPT + 99 others); Fri, 26 Mar 2021 11:50:34 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:48109 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbhCZPuJ (ORCPT ); Fri, 26 Mar 2021 11:50:09 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4F6RHp3FcVz9v0N7; Fri, 26 Mar 2021 16:49:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id GMS7qKW9a4qh; Fri, 26 Mar 2021 16:49:58 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4F6RHp1M13z9v0N3; Fri, 26 Mar 2021 16:49:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C764C8B8D7; Fri, 26 Mar 2021 16:49:59 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id UQFsEfZGymR7; Fri, 26 Mar 2021 16:49:59 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id CD5ED8B8C7; Fri, 26 Mar 2021 16:49:58 +0100 (CET) Subject: Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE To: Rob Herring Cc: Will Deacon , Daniel Walker , Daniel Gimpelevich , "open list:GENERIC INCLUDE/ASM HEADER FILES" , devicetree@vger.kernel.org, linuxppc-dev , "linux-kernel@vger.kernel.org" , linux-arm-kernel , microblaze , "open list:MIPS" , nios2 , Openrisc , linux-hexagon@vger.kernel.org, linux-riscv , X86 ML , linux-xtensa@linux-xtensa.org, SH-Linux , sparclinux References: <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu> From: Christophe Leroy Message-ID: Date: Fri, 26 Mar 2021 16:49:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 26/03/2021 à 16:47, Rob Herring a écrit : > On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy > wrote: >> >> This converts the architecture to GENERIC_CMDLINE. >> >> Signed-off-by: Christophe Leroy >> --- >> arch/arm/Kconfig | 38 +---------------------------------- >> arch/arm/kernel/atags_parse.c | 15 +++++--------- >> 2 files changed, 6 insertions(+), 47 deletions(-) >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 5da96f5df48f..67bc75f2da81 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -50,6 +50,7 @@ config ARM >> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY >> select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI >> select GENERIC_CLOCKEVENTS_BROADCAST if SMP >> + select GENERIC_CMDLINE if ATAGS > > Don't we need this enabled for !ATAGS (i.e. DT boot)? > > Can we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE? > Don't know. Today ARM has: choice prompt "Kernel command line type" if CMDLINE != "" default CMDLINE_FROM_BOOTLOADER depends on ATAGS Christophe