Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Mar 2021 12:50:15 -0300
User-Agent: K-9 Mail for Android
In-Reply-To: <80EE46ED-9007-4CB7-9A52-A7A2ADC616C6@linux.vnet.ibm.com>
References: <1616425047-1666-1-git-send-email-atrajeev@linux.vnet.ibm.com> <1616425047-1666-4-git-send-email-atrajeev@linux.vnet.ibm.com> <YFuWb3S8p0ZGjmGu@krava> <80EE46ED-9007-4CB7-9A52-A7A2ADC616C6@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH V2 3/5] tools/perf: Add powerpc support for PERF_SAMPLE_WEIGHT_STRUCT
To:     Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Jiri Olsa <jolsa@redhat.com>
CC:     linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        mpe@ellerman.id.au, acme@kernel.org, jolsa@kernel.org,
        Madhavan Srinivasan <maddy@linux.ibm.com>,
        ravi.bangoria@linux.ibm.com, kjain@linux.ibm.com,
        kan.liang@linux.intel.com, peterz@infradead.org
From:   Arnaldo <arnaldo.melo@gmail.com>
Message-ID: <F5813758-37E5-404D-BBC2-49F5BE6101C7@gmail.com>
Precedence: bulk


On March 26, 2021 12:23:04 PM GMT-03:00, Athira Rajeev <atrajeev@linux=2Ev=
net=2Eibm=2Ecom> wrote:
>
>
>On 25-Mar-2021, at 1:13 AM, Jiri Olsa <jolsa@redhat=2Ecom> wrote:
>
>On Mon, Mar 22, 2021 at 10:57:25AM -0400, Athira Rajeev wrote:
>
>Add arch specific arch_evsel__set_sample_weight() to set the new
>sample type for powerpc=2E
>
>Add arch specific arch_perf_parse_sample_weight() to store the
>sample->weight values depending on the sample type applied=2E
>if the new sample type (PERF_SAMPLE_WEIGHT_STRUCT) is applied,
>store only the lower 32 bits to sample->weight=2E If sample type
>is 'PERF_SAMPLE_WEIGHT', store the full 64-bit to sample->weight=2E
>
>Signed-off-by: Athira Rajeev <atrajeev@linux=2Evnet=2Eibm=2Ecom>
>---
>tools/perf/arch/powerpc/util/Build   |  2 ++
>tools/perf/arch/powerpc/util/event=2Ec | 32
>++++++++++++++++++++++++++++++++
>tools/perf/arch/powerpc/util/evsel=2Ec |  8 ++++++++
>3 files changed, 42 insertions(+)
>create mode 100644 tools/perf/arch/powerpc/util/event=2Ec
>create mode 100644 tools/perf/arch/powerpc/util/evsel=2Ec
>
>diff --git a/tools/perf/arch/powerpc/util/Build
>b/tools/perf/arch/powerpc/util/Build
>index b7945e5a543b=2E=2E8a79c4126e5b 100644
>--- a/tools/perf/arch/powerpc/util/Build
>+++ b/tools/perf/arch/powerpc/util/Build
>@@ -4,6 +4,8 @@ perf-y +=3D kvm-stat=2Eo
>perf-y +=3D perf_regs=2Eo
>perf-y +=3D mem-events=2Eo
>perf-y +=3D sym-handling=2Eo
>+perf-y +=3D evsel=2Eo
>+perf-y +=3D event=2Eo
>
>perf-$(CONFIG_DWARF) +=3D dwarf-regs=2Eo
>perf-$(CONFIG_DWARF) +=3D skip-callchain-idx=2Eo
>diff --git a/tools/perf/arch/powerpc/util/event=2Ec
>b/tools/perf/arch/powerpc/util/event=2Ec
>new file mode 100644
>index 000000000000=2E=2Ef49d32c2c8ae
>--- /dev/null
>+++ b/tools/perf/arch/powerpc/util/event=2Ec
>@@ -0,0 +1,32 @@
>+// SPDX-License-Identifier: GPL-2=2E0
>+#include <linux/types=2Eh>
>+#include <linux/string=2Eh>
>+#include <linux/zalloc=2Eh>
>+
>+#include "=2E=2E/=2E=2E/=2E=2E/util/event=2Eh"
>+#include "=2E=2E/=2E=2E/=2E=2E/util/synthetic-events=2Eh"
>+#include "=2E=2E/=2E=2E/=2E=2E/util/machine=2Eh"
>+#include "=2E=2E/=2E=2E/=2E=2E/util/tool=2Eh"
>+#include "=2E=2E/=2E=2E/=2E=2E/util/map=2Eh"
>+#include "=2E=2E/=2E=2E/=2E=2E/util/debug=2Eh"
>
>
>nit, just #include "utils/=2E=2E=2Eh" should work no?
>
>other than that, the patchset looks ok to me
>
>Acked-by: Jiri Olsa <jolsa@redhat=2Ecom>
>
>
>
>Hi Jiri, Arnaldo
>
>Thanks for reviewing the patch set=2E
>I checked that, just using "utils/=2E=2E=2Eh" also works=2E
>Below is the change which I verified=2E Since the patches are presently
>merged in=20
>https://git=2Ekernel=2Eorg/pub/scm/linux/kernel/git/acme/linux=2Egit/log/=
?h=3Dtmp=2Eperf/core,
>
>can you please suggest how can we go about this change ?

I'll fix it up here,

Thanks for the patch=2E

- Arnaldo

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E