Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1507840pxf; Fri, 26 Mar 2021 08:53:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxL6dkD3H+qOVgZlW7MgPoYs5ZJcK1jpFmp+qscfphR0hOVjdtgSWAhZRzbPUuyJYjYnpW5 X-Received: by 2002:a05:6402:4241:: with SMTP id g1mr16150252edb.331.1616774008688; Fri, 26 Mar 2021 08:53:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616774008; cv=none; d=google.com; s=arc-20160816; b=kyw1o7xkhPRORje7tnuM2LtZEURIexyhLfs7l4PDMXeUNAzaSlV34qIh12s6d7cMMg 8C2McnsCY0jizKu3py0ZDNt9/28NCN8XFDcW0/7p7+xdtqrySzwxrHAZXVtFKT/hX/bZ Jmf98v2m0I0aSx2bK6azksYMFn2L88fc2i+a0mA3/cNWDuA1Oe+XtyZtUwtq4UJu+U07 gSZHMp5eOPrd/c3a04ar2b+hNhUwtfdHjfCn4jqxkmd0v18GuXH5ASsobDrUDza04hPc PlX0p6RkunT2FLysoJTDvOwBens7nNUMwSbFlMD2XHxBFHSkSd7r6Up3yvU4ePF073cd CEfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=F6KRW9ZJsq6c47vOf7tfyaofFPNrEfYDeTWDF4l0gi8=; b=lzuSEla4aTiEOGnDmnBjOB/8kGAraACC8Vmn6ShrBjSdtY9T/rMuHLBNyXcOKSTSeS P/uhfDK8JclAAbI3OpDK3org0IyvL8N0wC/If531D1ulkNpoutRkIPyaPfjOhwPJ8AG8 W+LCrCyvpQLnP3m59j7sRrPByUzFSSX+BZLT5YdLLwF+NLK/V+nE9eoziLm4OWbLtUpl SIMEOvC0e+VYL9YWgEK9vUWblKHG9IW3KdAZ27b8syhxpkhrSTt1SKb2q7utuVOPTJwy Wc72+0XFYZ4OeyKb9W5AdSd2h6V67/+NPmLG9A60EZDs4r2BMhiXdOpRqbJFcGryOdmK po0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=vt05UeQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l33si7888204ede.161.2021.03.26.08.53.06; Fri, 26 Mar 2021 08:53:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=vt05UeQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230213AbhCZPwN (ORCPT + 99 others); Fri, 26 Mar 2021 11:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbhCZPwD (ORCPT ); Fri, 26 Mar 2021 11:52:03 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C82CC0613AA for ; Fri, 26 Mar 2021 08:52:03 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id u10so5472234ilb.0 for ; Fri, 26 Mar 2021 08:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F6KRW9ZJsq6c47vOf7tfyaofFPNrEfYDeTWDF4l0gi8=; b=vt05UeQjQ9LIsj4o4Ij/ce7suEu9EgJkPuxbBa8fOlejCAGJs4Nx6E3/nCYOxTgG5I Q+Ash89MMhYzZt2scu+lMsZjRhcZb00DuECcvZYFi4kc41U23pvdiK6B5AwaEtqsttFu RYx2zhd81zGIMRK+8NncSlc/xxGqGNI0h5Q8zKLhJ9IPmdJhNY1b4Ri3xZKX4YFQeRaP Qf6cXt58FjNaY4DiZIi6vh3Mjt2mnyQ5cq19Lk4m1tl6hPUhVrBHbHCeknQjR4UQufF+ Cz5XxYk4Ekns+B3HVpi1w3dzEs8VyhG3BEikaB8ZEYbkbq+kNPIeLJ95lbuyhANbINT2 leqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F6KRW9ZJsq6c47vOf7tfyaofFPNrEfYDeTWDF4l0gi8=; b=OS0vjJSSGgEZOE6s8iaWmKSGK1JpE3sEAhjEPja17i77BRysB2Hd9gkykZE2V6tD9W 2CbNA/5qy52c0vi0lSw2KoQy4ze8MH+22xOFIea8eRbdJYWlpUcZtPD5UFTh3jCDaHjW PCYUA7IPp/yhtzuVxh4hbHOTLCwRd4WTHj6cODy0gSFsutHvF3UrbZ9ht3ZilViKaUcX +Ob28znhJjnTU/y0xjtuavahga8uw2rCX9Sm68O4r8QJ9fIIkaffGJA+As5KciaGOIjY VFTclIZEFLjEwK1nFiWy5PXbJrT32b1ZjvC5IAQ2n+DUYsuJ/qtFoDOcQbrPefzcR7E0 XaxQ== X-Gm-Message-State: AOAM5318Td6D2MDcxdOr+jwxIyxUEamXMck0sV6jV117h6XmB8/o4jsf 3mPE0eYSHDSoUeCPP9JFfmRoEP6gFnCAZA== X-Received: by 2002:a92:c5a7:: with SMTP id r7mr1080255ilt.142.1616773922625; Fri, 26 Mar 2021 08:52:02 -0700 (PDT) Received: from p1.localdomain ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id a7sm4456337ilj.64.2021.03.26.08.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 08:52:02 -0700 (PDT) From: Jens Axboe To: io-uring@vger.kernel.org Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, metze@samba.org, oleg@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCHSET v2 0/7] Allow signals for IO threads Date: Fri, 26 Mar 2021 09:51:13 -0600 Message-Id: <20210326155128.1057078-1-axboe@kernel.dk> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, For the v1 posting, see here: https://lore.kernel.org/io-uring/20210326003928.978750-1-axboe@kernel.dk/ I've run this through the usual testing, and it's running long term right now. I've tested the cases that Stefan reported, and we seem fine now. Changes since v1: - Catch fatal signals in get_signal() for PF_IO_WORKER. This is only a problem for nested signals, like SIGSTOP followed by SIGKILL. We can't have get_signal() calling do_exit() on behalf of the IO threads, they have cleanups to do. Thanks Stefan. - Move signal masking to when the PF_IO_WORKER thread is created, and since we now handle SIGSTOP, unmask that as well. Thanks Oleg. - Remove try_to_freeze() parts in IO threads, we don't need those anymore with the calling of get_signal(). - Minor cleanups. fs/io-wq.c | 24 +++++++++++++++++------- fs/io_uring.c | 12 ++++++++---- kernel/fork.c | 16 ++++++++-------- kernel/freezer.c | 2 +- kernel/ptrace.c | 2 +- kernel/signal.c | 19 ++++++++++++------- 6 files changed, 47 insertions(+), 28 deletions(-) -- Jens Axboe