Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1510093pxf; Fri, 26 Mar 2021 08:56:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyx//5YT6OSJMYLCyyzqIUKnmV0iqyoT5cTkpeALXCITcOX0GPGVR6eZhxycCasOAe20ma0 X-Received: by 2002:a17:906:379b:: with SMTP id n27mr16709309ejc.182.1616774173303; Fri, 26 Mar 2021 08:56:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616774173; cv=none; d=google.com; s=arc-20160816; b=on9kLJ1I8qzAVUC1zPnoZjtXW9GF25ulpUxlO5g5A3paOj/Jps8nJm8eUz/rbfMxR4 P4XVZtHg3wb4Y9l9PfArttgfxXMTlVISGjcVBieBvEo6h/Am4TyJdBovJg5Wlj+M2d53 felTHluUIuoiADlc22rxCGREs6wAinddj1wnWMS3qYxuVKUBm5k0LJzOrVDkOM9CtMLN vkKyDAbKi0qoF6acbXe0tooF9Jz4k+8PnLMcW1OIxx2q8wrzVc63QexdOHwRcTscZ/PQ FK9uEjQ8Z4S5RpbJBn61JiLA0O0VJ0CpX/RFVtnnUMPXSuANmuIiURP5xF6ieoFZ5JnR Xwuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NTT4HsvI3kjbzvwySLsQmNjt7JR4etvocB0sNfxH6sA=; b=EdU3H9TCKXEdd1/uIlNLd2NnOG3fkRWOrleSEbDHdD1oKsTWZ3aIxNanNLVSsZZFd3 4JvRzRhXKb9p/Axj2YsPaMidQtIBwwGLljoEr4N3wyLM711r6CKL2gFvNNqv+tALdoFp LWqFQrqMp+EHTZn3GCJZyQLDLqcSQxevsY+mwE/iok+DsF2/JobmmGR86tjn5E+9yCl9 mhm5y2Iz/l9nmvvhL8310HWL/uIw0TzHGqXgGbQt8YPnOQZ7Bhk3MPIOLVmxuydoQ/7u j8Gs0dSoZYF12plCt9h4EslShyAq/M63X3eSf9IeiFTR7YzsquNL51gm4elNwl4LEhEZ M5WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=vTlCnlJh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si7190728edr.434.2021.03.26.08.55.50; Fri, 26 Mar 2021 08:56:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=vTlCnlJh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231354AbhCZPxB (ORCPT + 99 others); Fri, 26 Mar 2021 11:53:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbhCZPwP (ORCPT ); Fri, 26 Mar 2021 11:52:15 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 506ABC0613B4 for ; Fri, 26 Mar 2021 08:52:15 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id x17so5875432iog.2 for ; Fri, 26 Mar 2021 08:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NTT4HsvI3kjbzvwySLsQmNjt7JR4etvocB0sNfxH6sA=; b=vTlCnlJhHEG4rMMQ5bt1Sd3zNpAol+alVO3sVPstXTCedpEvmJ74f+p1MKvd1x3Zjg esjyVJ+vE9oGvBHklpobdVkX3/js61qy2woCpK9mE4VC4o2nR486fTZq2AcKJ/mYrljv DkDbuT1li7r5yTTyY0Ho8U1BgjDgMRQRwOgbPPtXuqZD3W9J6FG927fc32qTaX3Zi3LF 19zl+cxUapY9vJ+J59bfaxblVdHs43kGB7awBrOajQ97dyAahG1HFdPnPdIJU6xylaqs /Yx0+OmlhyJHdLjGZOWrCanf4sT1Sk0tECEDAdq6rttcqZQecwPL7iQaypChV+HGIStN msSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NTT4HsvI3kjbzvwySLsQmNjt7JR4etvocB0sNfxH6sA=; b=h0pBLuKb8W8Ao0NSDe07UDH8luj3RON1dBfTrcnbM6Qkp6m0o8yzeXzIHIdueQ6tQ8 Su0S/XLvUH5EvilH6vlgWIypJmk6inQPw3BF5QkSs8xFEbD0fHLxSv4slfjLzmxNAGl3 Al1KSyvIZe15WT6aZWuCWv93B3vHA3mKBvnC0R6cwT/HfU6Y84KXjJeMNUN98ATzFEiY mDmvQoAlV5hXrLNS4YCqi2eJfnhwDgVnID1J3k2OUk5Qg7G9uuKIhlWZZgTf9/4uqZcE aQ4glit5zsdNqkBgQ5nLd/oPBl+7DGzqRBBfxXkcainmnmI5XcFDiv5mKVxEC4sKz5lY qiMw== X-Gm-Message-State: AOAM531NXZ2f1FHMsJGqKHjqu4W1b1s+CjFWG4oJbdxqErCAH33fBYCl a6ddFSopzaHO80QJHkD2qrppUg== X-Received: by 2002:a05:6638:d47:: with SMTP id d7mr12473118jak.2.1616773934732; Fri, 26 Mar 2021 08:52:14 -0700 (PDT) Received: from p1.localdomain ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id a7sm4456337ilj.64.2021.03.26.08.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 08:52:14 -0700 (PDT) From: Jens Axboe To: io-uring@vger.kernel.org Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, metze@samba.org, oleg@redhat.com, linux-kernel@vger.kernel.org, Pavel Begunkov , Jens Axboe Subject: [PATCH 09/10] io_uring: don't cancel-track common timeouts Date: Fri, 26 Mar 2021 09:51:27 -0600 Message-Id: <20210326155128.1057078-15-axboe@kernel.dk> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210326155128.1057078-1-axboe@kernel.dk> References: <20210326155128.1057078-1-axboe@kernel.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Begunkov Don't account usual timeouts (i.e. not linked) as REQ_F_INFLIGHT but keep behaviour prior to dd59a3d595cc1 ("io_uring: reliably cancel linked timeouts"). Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/104441ef5d97e3932113d44501fda0df88656b83.1616696997.git.asml.silence@gmail.com Signed-off-by: Jens Axboe --- fs/io_uring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index 69896ae204d6..4189e1b684e1 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -5563,7 +5563,8 @@ static int io_timeout_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe, data->mode = io_translate_timeout_mode(flags); hrtimer_init(&data->timer, CLOCK_MONOTONIC, data->mode); - io_req_track_inflight(req); + if (is_timeout_link) + io_req_track_inflight(req); return 0; } -- 2.31.0