Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tomoyo: don't special case PF_IO_WORKER for PF_KTHREAD
To:     Jens Axboe <axboe@kernel.dk>,
        Kentaro Takeda <takedakn@nttdata.co.jp>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc:     linux-security-module@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <46f6e3cb-cc96-d214-e183-71dd238da075@kernel.dk>
From:   Casey Schaufler <casey@schaufler-ca.com>
Message-ID: <935b000c-77df-fa88-6e2e-daffc256a11e@schaufler-ca.com>
Date:   Fri, 26 Mar 2021 09:03:31 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <46f6e3cb-cc96-d214-e183-71dd238da075@kernel.dk>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Length: 905
Precedence: bulk

On 3/25/2021 5:44 PM, Jens Axboe wrote:
> The io_uring PF_IO_WORKER threads no longer have PF_KTHREAD set, so no
> need to special case them for credential checks.

Could you cite the commit where that change was made?

>
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
>  security/tomoyo/network.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/tomoyo/network.c b/security/tomoyo/network.c
> index 478f757ff843..8dc61335f65e 100644
> --- a/security/tomoyo/network.c
> +++ b/security/tomoyo/network.c
> @@ -613,7 +613,7 @@ static int tomoyo_check_unix_address(struct sockaddr *addr,
>  static bool tomoyo_kernel_service(void)
>  {
>  	/* Nothing to do if I am a kernel service. */
> -	return (current->flags & (PF_KTHREAD | PF_IO_WORKER)) == PF_KTHREAD;
> +	return current->flags & PF_KTHREAD;
>  }
>  
>  /**