Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1616777074-5151-1-git-send-email-Vijendar.Mukunda@amd.com> <1616777074-5151-2-git-send-email-Vijendar.Mukunda@amd.com>
In-Reply-To: <1616777074-5151-2-git-send-email-Vijendar.Mukunda@amd.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Fri, 26 Mar 2021 17:44:50 +0100
Message-ID: <CAK8P3a0aM4GRZ62TvNpwtMY0Bw7JGJNVs55UkpdBVYeKgWhMaQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] ASoC: amd: fix acpi dependency kernel warning
To:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc:     Mark Brown <broonie@kernel.org>,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Alex Deucher <Alexander.Deucher@amd.com>,
        Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@amd.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 26, 2021 at 5:44 PM Vijendar Mukunda
<Vijendar.Mukunda@amd.com> wrote:
>
> Fix ACPI dependency kernel warning produced by powerpc
> allyesconfig.
>
> sound/soc/amd/acp-da7219-max98357a.c:684:28: warning:
> 'cz_rt5682_card' defined but not used [-Wunused-variable]
>
> sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card'
> defined but not used [-Wunused-variable]

I would suggest simply dropping the unnecessary #ifdef and
ACPI_PTR() guard.

It might be helpful to hide the Kconfig submenu under
'depends on X86 || COMPILE_TEST'.

       Arnd