Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1624323pxf; Fri, 26 Mar 2021 11:03:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBRZ3X3bFUA8ZpvHEfd3NSrdJWTety74y1J8Try1uD7QEKlGPBJS7kzxPp9yFx+mDWHd0j X-Received: by 2002:aa7:dad7:: with SMTP id x23mr16472134eds.292.1616781829519; Fri, 26 Mar 2021 11:03:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616781829; cv=none; d=google.com; s=arc-20160816; b=gfs6/LtYmBg/gNB3GSv/CA8KiJi7vYPdI3E2HCJmxu+Tm1TkGHACNcw1NQ8pf5MTzT /QDPV85CAyvcjwhwAZiCVxoWUMgCHbZg5z3Y7KeJ1SFrpYZVLDNb2G2IIzCClowlcg4F 1W6jwCkGn6drDSKPWOqqor//QaxAPRh/djynx05V0A8ZJz7X4DO4DUQ3z3tVrzXXy397 f//eVpNQTn0IpBrH+UF7J5qaTf4PX9qonCkDv8Zh+syyi4iOe5IGdmcqgiet6UodD6Vw xJm3TZch/omiCVrSj1zpNFiCukU+AbCFcXVctmVA31DK0ug9NWugm3P9O8pgbQrXViBr sz5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=sTtckNqfgPJECPo3DysCtidoRhR82TGqjwDr082dzvc=; b=UFtmynW+K9d44k7FC6aw4XAdKTrZAyXeNrIF6ubUIaIIXmJqPiS9NDGv9WqfC4ES0p ZOrQuR2Gd+O69FlscQCV9AgFUuKVaj0XE9MZMBRNy6Icbi8qU/InyLVrX4Ue/2O1jmcV gLz/JD/+vimcpWv1LvtcInGtNqMkEgk9u/zIpHsuCMhotqDZvDPU4Tzi/U4UQ3oe1Oxi QK5tLNtMb32xK3jMOlu+41XHN6WD5eNeSECiPL/qSeDjWrmS0cHZNGzpXTBa3R2QvcW9 g4sPwwGlYwxoiMLzd1AHVixXSizOoy+yEJXmb7/5iZ29IW/e0lW5TTVS4F6FgX83w6hj 4CSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HomMG5tm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si7265915ejq.299.2021.03.26.11.03.26; Fri, 26 Mar 2021 11:03:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HomMG5tm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbhCZSC1 (ORCPT + 99 others); Fri, 26 Mar 2021 14:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230107AbhCZSCV (ORCPT ); Fri, 26 Mar 2021 14:02:21 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C257EC0613AA; Fri, 26 Mar 2021 11:02:20 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id ha17so2938644pjb.2; Fri, 26 Mar 2021 11:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sTtckNqfgPJECPo3DysCtidoRhR82TGqjwDr082dzvc=; b=HomMG5tmEE57XL9UIQbKSe3ws0sltJL4iaupR7VFjVqM1YI91NSi7ki8cYXfIdaACT EDp5XeM96/4RSzm/womxj3+9BulgMihM4RzbsjzXc81sUgks1Ktb8MnmcBRrwY1sNVwd NUq/GCJN6brC1caudBGuNt6+WiT2mP1IhHWm75tORLvvX3cy1QjU2AGsrXkLPd4Z/IcG Gv9E6j0kdhneKcVJuxw2tpsTaUenMyhyqmBUatew1rqQtlaVvB5KFTvm87k1qfg78Faj hVRftML1t3fFQ0hNza1R3Q7ytWTx+4aSK3LjYFyt5iQtOoex28P6YKf6ACu15JKfaqtg XeUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sTtckNqfgPJECPo3DysCtidoRhR82TGqjwDr082dzvc=; b=tQqklmT4/m8WqcYftI9ZUQ3SpFLKC3UIIjlX8JAsNX6PkiydsznuXO2xrfgd6jMJZP r99R0WYPwemSyfsmhFCQS+tGbOTrXx6gz1cCBWITZmiMQMi5JOzZrPafqLvd2e7xGFVx URDUEhon/ROOgmGIp4y0sbGajE1s+JUbjZijYLm/J6LSFBEv1HHD8XFPuPPxnTcX1tL2 4+ClLnFBGjTcwwQnrVJjVdjduD76nOHMm0n7W8xFlBedGpTUm9nexoJ0msmxvW9DqvBM Qa1JohZdNLvTp4sWF/gt0LAF9FzBh5j4qBiwbLjXLl3FmqTmXO3yg6i1mh/qBEBMllVL PYnw== X-Gm-Message-State: AOAM5303uuvyPP1Y5XiDgm/JheMXGQ5cYIAVIRybkTjp5gMP/hx1aX0Q 1DDV6RLA3GBYfzakqHp9jJC8hzt0EDNGIQ1afWc= X-Received: by 2002:a17:90a:b311:: with SMTP id d17mr15149555pjr.228.1616781740355; Fri, 26 Mar 2021 11:02:20 -0700 (PDT) MIME-Version: 1.0 References: <4c259d34b5943bf384fd3cb0d98eccf798a34f0f.1615038553.git.syednwaris@gmail.com> In-Reply-To: <4c259d34b5943bf384fd3cb0d98eccf798a34f0f.1615038553.git.syednwaris@gmail.com> From: Andy Shevchenko Date: Fri, 26 Mar 2021 20:02:04 +0200 Message-ID: Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value To: Syed Nayyar Waris Cc: Bartosz Golaszewski , Andy Shevchenko , William Breathitt Gray , Michal Simek , Arnd Bergmann , Robert Richter , Linus Walleij , Masahiro Yamada , Andrew Morton , "Zhang, Rui" , Daniel Lezcano , Amit Kucheria , Linux-Arch , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-arm Mailing List , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris wrote: > + bitmap_set_value(old, 64, state[0], 32, 0); > + bitmap_set_value(old, 64, state[1], 32, 32); Isn't it effectively bitnap_from_arr32() ? > + bitmap_set_value(new, 64, state[0], 32, 0); > + bitmap_set_value(new, 64, state[1], 32, 32); Ditto. -- With Best Regards, Andy Shevchenko